Skip to content

[chore] Add e2e test for eks detector#45486

Merged
songy23 merged 2 commits into
open-telemetry:mainfrom
iblancasa:24671-eks
Jan 21, 2026
Merged

[chore] Add e2e test for eks detector#45486
songy23 merged 2 commits into
open-telemetry:mainfrom
iblancasa:24671-eks

Conversation

@iblancasa
Copy link
Copy Markdown
Contributor

@iblancasa iblancasa commented Jan 19, 2026

Description

Link to tracking issue

Updates #24671

Testing

Documentation

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa requested review from a team and dashpole as code owners January 19, 2026 17:03
@iblancasa iblancasa marked this pull request as draft January 19, 2026 17:03
@github-actions github-actions Bot added the processor/resourcedetection Resource detection processor label Jan 19, 2026
@github-actions github-actions Bot requested a review from Aneurysm9 January 19, 2026 17:04
@iblancasa iblancasa changed the title Add e2e test for eks detector [chore] Add e2e test for eks detector Jan 19, 2026
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa marked this pull request as ready for review January 20, 2026 09:42
Copy link
Copy Markdown
Member

@paulojmdias paulojmdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I just think when the certificate expires (I know still there 10y left 😅), the test should maybe start failing.

Maybe we should open an issue to revisit this, and dynamic generate the certs (CA and Cert) with a short validity when the test starts.

@paulojmdias paulojmdias added the ready to merge Code review completed; ready to merge by maintainers label Jan 20, 2026
@songy23 songy23 merged commit 50674a7 into open-telemetry:main Jan 21, 2026
212 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

processor/resourcedetection Resource detection processor ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants