[chore] Add e2e test for eks detector#45486
Merged
Merged
Conversation
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
paulojmdias
reviewed
Jan 19, 2026
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
paulojmdias
approved these changes
Jan 20, 2026
Member
There was a problem hiding this comment.
Overall LGTM, I just think when the certificate expires (I know still there 10y left 😅), the test should maybe start failing.
Maybe we should open an issue to revisit this, and dynamic generate the certs (CA and Cert) with a short validity when the test starts.
dashpole
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Updates #24671
Testing
Documentation