Skip to content

[chore] Move test package to internal#44761

Merged
ChrsMark merged 18 commits into
open-telemetry:mainfrom
rakesh-garimella:move-test-package-to-internal
Dec 10, 2025
Merged

[chore] Move test package to internal#44761
ChrsMark merged 18 commits into
open-telemetry:mainfrom
rakesh-garimella:move-test-package-to-internal

Conversation

@rakesh-garimella
Copy link
Copy Markdown
Contributor

@rakesh-garimella rakesh-garimella commented Dec 5, 2025 •
edited by ChrsMark
Loading

Description

  • Copy fake extension test api into internal package.

Link to tracking issue

Part of 43992

Testing

Documentation

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 5, 2025
@rakesh-garimella rakesh-garimella changed the title Move test package to internal [chore] Move test package to internal Dec 8, 2025
@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Dec 9, 2025

@rakesh-garimella I think you will need to split this into 2 PRs. See #43108 (comment)

@rakesh-garimella
Copy link
Copy Markdown
Contributor Author

rakesh-garimella commented Dec 9, 2025

@rakesh-garimella I think you will need to split this into 2 PRs. See #43108 (comment)

hi @ChrsMark I am using replace directive to reference the internal package. I think if I want to merge first into internal package then there will duplicate code as I wont be able to delete from the existing location: extensions/k8sleaderelector/k8sleaderelectortest which is used by other receivers

@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Dec 9, 2025

@rakesh-garimella I think you will need to split this into 2 PRs. See #43108 (comment)

hi @ChrsMark I am using replace directive to reference the internal package. I think if I want to merge first into internal package then there will duplicate code as I wont be able to delete from the existing location: extensions/k8sleaderelector/k8sleaderelectortest which is used by other receivers

I think it's fine to have duplicate code for a while and then remove it with a second PR.

@github-actions github-actions Bot requested a review from povilasv December 10, 2025 07:35
@ChrsMark ChrsMark merged commit bd470ae into open-telemetry:main Dec 10, 2025
191 of 192 checks passed
@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Dec 10, 2025

@rakesh-garimella merged. Feel free to apply the second part in a follow-up PR

@github-actions github-actions Bot added this to the next release milestone Dec 10, 2025
@paulojmdias paulojmdias mentioned this pull request Dec 10, 2025
Merged
mx-psi pushed a commit that referenced this pull request Dec 10, 2025
@paulojmdias
[chore] update chloggen config (#44872)
56f99d6 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Add missing `internal/k8sleaderelectortest` to the chloggen config
running `make generate-chloggen-components` command.


https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/20094969552/job/57651005585?pr=44863

This was introduced in
#44761

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@rakesh-garimella rakesh-garimella mentioned this pull request Dec 10, 2025
Merged
ChrsMark pushed a commit that referenced this pull request Dec 11, 2025
@rakesh-garimella
[chore] refactor to use new k8sleaderelectortest package (#44876)
7b200dc 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
- Followup change for:
#44761
- Use the new internal package for tests
- Remove duplicate package in extensions 
<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
#44761

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

@povilasv povilasv Awaiting requested review from povilasv

Assignees

@ArthurSens ArthurSens

Labels

extension/k8sleaderelector receiver/k8scluster receiver/k8sevents receiver/k8sobjects Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v0.142.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rakesh-garimella @ChrsMark @dmitryax @ArthurSens