Skip to content

[receiver/pprof] convert pprof to profile data in a receiver#44385

Closed
atoulme wants to merge 3 commits into
open-telemetry:mainfrom
atoulme:attempt_to_convert_pprof
Closed

[receiver/pprof] convert pprof to profile data in a receiver#44385
atoulme wants to merge 3 commits into
open-telemetry:mainfrom
atoulme:attempt_to_convert_pprof

Conversation

@atoulme
Copy link
Copy Markdown
Contributor

@atoulme atoulme commented Nov 18, 2025

Implement #38260

@atoulme atoulme force-pushed the attempt_to_convert_pprof branch 2 times, most recently from 556f577 to 6177e0a Compare November 18, 2025 23:48
atoulme
atoulme commented Nov 18, 2025
View reviewed changes
Comment thread pkg/translator/pprof/profiles_to_pprof.go Outdated
@atoulme atoulme force-pushed the attempt_to_convert_pprof branch 4 times, most recently from d54645c to b479479 Compare November 19, 2025 05:03
@atoulme atoulme changed the title [receiver/pprof] WIP - convert pprof to profile data in a receiver [receiver/pprof] convert pprof to profile data in a receiver Nov 19, 2025
@atoulme atoulme force-pushed the attempt_to_convert_pprof branch 2 times, most recently from d13eb3d to 95a9c4b Compare November 19, 2025 17:05
@atoulme atoulme marked this pull request as ready for review November 19, 2025 18:11
@atoulme atoulme requested review from a team and MovieStoreGuy as code owners November 19, 2025 18:11
MovieStoreGuy
MovieStoreGuy reviewed Nov 20, 2025
View reviewed changes
Comment thread receiver/pprofreceiver/config.go Outdated
Comment thread receiver/pprofreceiver/factory.go Outdated
Comment thread receiver/pprofreceiver/README.md
@atoulme atoulme force-pushed the attempt_to_convert_pprof branch 4 times, most recently from 67b2370 to c7274dc Compare November 22, 2025 06:47
MovieStoreGuy
MovieStoreGuy approved these changes Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look sensible to me.

Following up on the API design for the translate package on the thread directly.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 9, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Dec 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 23, 2025

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions Bot closed this Dec 23, 2025
@atoulme atoulme mentioned this pull request Jan 14, 2026
Merged
@atoulme
Copy link
Copy Markdown
Contributor Author

atoulme commented Jan 14, 2026

Reopening as we're getting closer to unblocked.

@atoulme atoulme reopened this Jan 14, 2026
@github-actions github-actions Bot removed the Stale label Jan 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 29, 2026

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Jan 29, 2026
@atoulme atoulme force-pushed the attempt_to_convert_pprof branch from c7274dc to 1397405 Compare February 4, 2026 06:14
@atoulme atoulme force-pushed the attempt_to_convert_pprof branch from 1397405 to 41348b0 Compare February 4, 2026 06:26
florianl
florianl reviewed Feb 4, 2026
View reviewed changes
Comment thread receiver/pprofreceiver/factory_test.go
require.NoError(t, err)
cfg := f.CreateDefaultConfig().(*Config)
cfg.CollectionInterval = 1 * time.Second
cfg.Endpoint = "http://localhost:6060/debug/pprof/profile?seconds=1"
Copy link
Copy Markdown
Member

@florianl florianl Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be some configuration validation to make sure cfg.CollectionInterval does not conflicts with interval configured in cft.Endpoint.

In this test they are the same:

  • cfg.CollectionInterval = 1 * time.Second
  • cfg.Endpoint = "http://localhost:6060/debug/pprof/profile?seconds=1"

What is the expected behaviour if cfg.CollectionInterval << cfg.Endpoint interval?
iirc the default interval for the /debug/pprof/profile endpoint is 30 seconds.

@github-actions github-actions Bot removed the Stale label Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Feb 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions Bot closed this Mar 6, 2026
@atoulme atoulme reopened this Mar 9, 2026
@atoulme
Copy link
Copy Markdown
Contributor Author

atoulme commented Mar 10, 2026

Closing in favor of #46781

@atoulme atoulme closed this Mar 10, 2026
@florianl florianl mentioned this pull request Mar 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

+1 more reviewer

@florianl florianl florianl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TylerHelmuth TylerHelmuth

Labels

pkg/translator/pprof receiver/pprof Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atoulme @florianl @MovieStoreGuy @TylerHelmuth