[chore][receiver/k8scluster] Prevent concurrent metadata access by reordering initialization#44136
Merged
ChrsMark merged 12 commits intoDec 17, 2025
Merged
Conversation
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
paulojmdias
requested review from
a team,
ChrsMark,
TylerHelmuth and
dmitryax
as code owners
Member
|
Instead of adding a mutex, I think we can just remove the chance of concurrent calls by running |
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Member
Author
|
Thanks for the heads-up @dmitryax. I proceed accordingly, PTAL when you have a chance. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
ChrsMark
approved these changes
Dec 17, 2025
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
LGTM based on #44136 (comment).
Please tune the PR tittle to reflect the current implemention :)
paulojmdias
changed the title
Member
Author
Done. Thank you @ChrsMark 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add RWMutex protection for
metadataConsumersandentityLogConsumerfields in resourceWatcher to prevent potential data races during concurrent access.Link to tracking issue
Relates to #43084 (comment)