Skip to content

[extension/headersetter] Add support for chaining with other auth extensions#44120

Merged
songy23 merged 4 commits into
open-telemetry:mainfrom
kushalShukla-web:chaining
Nov 19, 2025
Merged

[extension/headersetter] Add support for chaining with other auth extensions#44120
songy23 merged 4 commits into
open-telemetry:mainfrom
kushalShukla-web:chaining

Conversation

@kushalShukla-web

@kushalShukla-web kushalShukla-web commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

Description

This PR adds support for chaining the headersetter extension with other authentication extensions (e.g., OAuth2).
It introduces a new configuration parameter additional_auth in headersetter and ensures that the additional auth extension is started first using the Dependent interface.

Link to tracking issue

Fixes #43935

@kushalShukla-web kushalShukla-web requested review from a team and VihasMakwana as code owners November 9, 2025 19:42
@github-actions github-actions Bot added the first-time contributor PRs made by new contributors label Nov 9, 2025
@github-actions

github-actions Bot commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@VihasMakwana

Copy link
Copy Markdown
Contributor

cc: @eduardscaueru

Comment thread extension/headerssetterextension/extension.go Outdated
@VihasMakwana

Copy link
Copy Markdown
Contributor

@kushalShukla-web Can you run make gotidy and commit the changes?

@kushalShukla-web

Copy link
Copy Markdown
Contributor Author

@kushalShukla-web Can you run make gotidy and commit the changes?

I ran make gotidy and also tried go mod tidy manually. No changes were produced, and the working tree is clean. Could you confirm if there’s any specific Go version or environment requirement?

Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
@kushalShukla-web

Copy link
Copy Markdown
Contributor Author

@VihasMakwana shall we merge this pr ?

@VihasMakwana VihasMakwana added the ready to merge Code review completed; ready to merge by maintainers label Nov 19, 2025
@songy23 songy23 merged commit a286349 into open-telemetry:main Nov 19, 2025
204 of 205 checks passed
@otelbot

otelbot Bot commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution @kushalShukla-web! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension/headerssetter first-time contributor PRs made by new contributors ready to merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[extension/headersetter] Support chaining with other auth providers

5 participants