Fix race condition in bearertokenauth extension, the dobule removal of watcher#44104
Merged
songy23 merged 3 commits intoNov 10, 2025
Merged
Conversation
…f watcher Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
…f watcher Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
atoulme
reviewed
Nov 7, 2025
| component: extension/bearertokenauth | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Remove error messages `fsnotify: can't remove non-existent watch` when watching kubernetes SA tokens. |
Contributor
There was a problem hiding this comment.
Suggested change
| note: Remove error messages `fsnotify: can't remove non-existent watch` when watching kubernetes SA tokens. | |
| note: "Remove error messages `fsnotify: can't remove non-existent watch` when watching kubernetes SA tokens." |
frzifus
approved these changes
Nov 9, 2025
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The error means the code called watcher.Remove(path) on a file that the fsnotify watcher was already no longer watching.
In the specific case of the Kubernetes service account token, this happens because Kubernetes rotates the token by deleting and replacing the file (it's an atomic update).
Link to tracking issue
Fixes
Testing
Documentation