[receiver/googlecloudpubsubpush] Add implementation#44101
Merged
songy23 merged 23 commits intoNov 19, 2025
Conversation
constanca-m
commented
Nov 7, 2025
constanca-m
commented
Nov 7, 2025
atoulme
reviewed
Nov 17, 2025
atoulme
reviewed
Nov 17, 2025
…' into googlecloudpubsub-implementation
# Conflicts: # receiver/googlecloudpubsubpushreceiver/go.mod # receiver/googlecloudpubsubpushreceiver/go.sum
axw
reviewed
Nov 18, 2025
axw
left a comment
axw
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, mostly quibbles
constanca-m
commented
Nov 19, 2025
Comment on lines
+85
to
+98
| // Pub/Sub retries everything that is not a valid response. A valid response | ||
| // has the following HTTP codes: [102, 200, 201, 202, 204]. | ||
| // You can verify this in the official documentation. For this, refer to | ||
| // https://cloud.google.com/pubsub/docs/push. | ||
| // | ||
| // This becomes an issue for permanent errors, because it means that if we | ||
| // don't return one of those codes, Pub/Sub will keep retrying. This would | ||
| // only stop retrying if: | ||
| // 1. We add event arc advanced after Pub/Sub. For this, we need to set the | ||
| // correct HTTP code for permanent/transient errors. You can refer to | ||
| // the official documentation for this. See: | ||
| // https://docs.cloud.google.com/eventarc/advanced/docs/retry-events#transient | ||
| // 2. Or return 2xx for permanent errors. Since this is not semantically correct, | ||
| // we are holding on this option. |
Contributor
Author
There was a problem hiding this comment.
@axw Here is the comment. What do you think of it? Is it time for us to return 2xx for permanent errors? I feel torn on it. It doesn't seem right, but at the same time, it is wrong to retry permanent errors
Contributor
There was a problem hiding this comment.
Thanks, that's very clear. It seems there's no perfect solution here, so we could consider adding configuration to control the response code in the case of permanent errors. Maybe in a followup?
Contributor
Author
There was a problem hiding this comment.
Yes, that's fine by me
axw
reviewed
Nov 19, 2025
| // 2. Or return 2xx for permanent errors. Since this is not semantically correct, | ||
| // we are holding on this option. | ||
| logger.Error("failed to handle Pub/Sub push request", zap.Error(err)) | ||
| code := http.StatusInternalServerError |
Contributor
There was a problem hiding this comment.
I think we should still use different status codes depending on the gRPC error codes for retryable errors, but we can do that in a followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add implementation to the googlecloudpubsubpush receiver.
Testing
Unit tests added.
Documentation
README already up to date.