[chore][exporter/loadbalancing] migrate from using deprecated k8s API#44079
Conversation
axw
left a comment
There was a problem hiding this comment.
Code looks good. Does this impact Kubernetes version compatibility at all?
I feel it would be worth adding a changelog entry even if it's not meant to have any user impact, so users can find the change in the release notes in case of any unexpected behaviour.
If I am correct, this should shift the k8s version to 1.21 (instead of 1.17), so realistically, this should not affect users using the latest collector builds. I am not completely sure about the changelog, if yes, it should cover all components linked in the issue and not only the loadbalancing exporter |
Thanks, that was my read of the docs too. I think we should still call this out as a breaking change, despite Kubernetes 1.20 being ~5 years old. Doesn't hurt does it?
This PR is only changing the loadbalancing exporter though. We can add an entry for each component change? |
I agree it would not hurt, but effectively it should realistically not affect any user. If you would agree, I would add a changelog entry for |
Ah ok, didn't see the others. SGTM. |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
034d3db to
7fda262
Compare
Link to tracking issue
Part of #43891