fix[receiver/sqlquery]: Null value logs collection#43985
Merged
songy23 merged 4 commits intoNov 18, 2025
Conversation
mrsillydog
requested review from
a team,
crobert-1 and
dmitryax
as code owners
crobert-1
approved these changes
Nov 17, 2025
Member
|
Thanks for filing the issue and fixing as well, @mrsillydog, really appreciate your help! |
crobert-1
added
the
ready to merge
benchub
added a commit
to benchub/opentelemetry-collector-contrib
that referenced
this pull request
Mar 5, 2026
This enhancement to NULL value handling allows for cleaner logs when a query cannot be formulated to hide NULL values. For example, the SQL interface to pgBouncer is a handy way to monitor that service, but the minimal SQL parsing of the interface does not allow for a subset of columns to be returned. As a result, NULL values are common in the returned rows, even if they will not be used by the receiver. Link to tracking issue Enhances open-telemetry#43985 Testing Unit testing showing that the existence of ignore_null_values=true supresses warnings, unless the null values are in a referenced column. Likewise, tests that show the default value, or explicitly setting the value to false, keeps the warnings around. Errors always remain when a columned holding NULL values is referenced.
songy23
pushed a commit
that referenced
this pull request
Apr 15, 2026
#### Description This enhancement to NULL value handling allows for cleaner logs when a query cannot be formulated to hide NULL values. For example, the SQL interface to pgBouncer is a handy way to monitor that service, but the minimal SQL parsing of the interface does not allow for a subset of columns to be returned. As a result, NULL values are common in the returned rows, even if they will not be used for monitoring. #### Link to tracking issue Enhances #43985 #### Testing Unit testing showing that the existence of ignore_null_values=true suppresses warnings, unless the null values are in a referenced column. Likewise, tests that show the default value, or explicitly setting the value to false, keeps the warnings around. Errors always remain when a columned holding NULL values is referenced. #### Documentation Documented the new option, and referenced it when talking about NULL values in README.md.
AndrewCharlesHay
pushed a commit
to AndrewCharlesHay/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2026
…emetry#46660) #### Description This enhancement to NULL value handling allows for cleaner logs when a query cannot be formulated to hide NULL values. For example, the SQL interface to pgBouncer is a handy way to monitor that service, but the minimal SQL parsing of the interface does not allow for a subset of columns to be returned. As a result, NULL values are common in the returned rows, even if they will not be used for monitoring. #### Link to tracking issue Enhances open-telemetry#43985 #### Testing Unit testing showing that the existence of ignore_null_values=true suppresses warnings, unless the null values are in a referenced column. Likewise, tests that show the default value, or explicitly setting the value to false, keeps the warnings around. Errors always remain when a columned holding NULL values is referenced. #### Documentation Documented the new option, and referenced it when talking about NULL values in README.md.
gracewehner
pushed a commit
to gracewehner/opentelemetry-collector-contrib
that referenced
this pull request
Apr 29, 2026
…emetry#46660) #### Description This enhancement to NULL value handling allows for cleaner logs when a query cannot be formulated to hide NULL values. For example, the SQL interface to pgBouncer is a handy way to monitor that service, but the minimal SQL parsing of the interface does not allow for a subset of columns to be returned. As a result, NULL values are common in the returned rows, even if they will not be used for monitoring. #### Link to tracking issue Enhances open-telemetry#43985 #### Testing Unit testing showing that the existence of ignore_null_values=true suppresses warnings, unless the null values are in a referenced column. Likewise, tests that show the default value, or explicitly setting the value to false, keeps the warnings around. Errors always remain when a columned holding NULL values is referenced. #### Documentation Documented the new option, and referenced it when talking about NULL values in README.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change prevents log collection from being fully halted by a single log with a NULL value. Instead, logs should drop NULL values, and other logs will be collected normally.
Link to tracking issue
Fixes #43984
Testing
Unit testing to ensure that the receiver would not error upon receiving
ErrNullValueWarningfrom DBClient.QueryRows.Manual testing with a distribution of the collector built off of this branch.