[extension/tailsampling] Add example tail sampling extension#43972
Closed
csmarchbanks wants to merge 1 commit into
Closed
[extension/tailsampling] Add example tail sampling extension#43972csmarchbanks wants to merge 1 commit into
csmarchbanks wants to merge 1 commit into
Conversation
csmarchbanks
force-pushed
the
tailsampling-extension-example
branch
from
09a321f to
6a26dbd
Compare
csmarchbanks
force-pushed
the
tailsampling-extension-example
branch
5 times, most recently
from
516a3b4 to
df57fef
Compare
This PR adds directory to contain tail sampling extensions as well as an example of creating an extension. The example is for reference for future extension authors, not to be actually ran anywhere.
csmarchbanks
force-pushed
the
tailsampling-extension-example
branch
from
df57fef to
09fe49d
Compare
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds directory to contain tail sampling extensions as well as an example of creating an extension. The example is for reference for future extension authors, not to be actually ran anywhere. See the request in #41877 (comment) for what motivated this work.
I don't know if we actually want to have what is effectively a no-op sampler in this repo. If we do not, I am happy to extract just the folder structure and README into a separate PR and just have this PR for reference.
Documentation
Documentation for how this was done was added to a new README for future use.