[pkg/translator/zipkin] Unexport ToTranslator#43852
Merged
Merged
Conversation
atoulme
requested review from
a team,
MovieStoreGuy,
andrzej-stencel and
crobert-1
as code owners
atoulme
force-pushed
the
zipkin_pkg_api
branch
from
0bddd83 to
2f889a7
Compare
codeboten
approved these changes
Oct 29, 2025
dmitryax
added a commit
that referenced
this pull request
Nov 4, 2025
Reverts #43852 Given that we provide pdata->zipkin API, we should keep providing the curated API for Zipkin->pdata translation as long as we offer zipkin receiver. It's being used in the Splunk distro where we don't want diverge from the OTel specification.
jelly-afk
pushed a commit
to jelly-afk/opentelemetry-collector-contrib
that referenced
this pull request
Nov 6, 2025
Reverts open-telemetry#43852 Given that we provide pdata->zipkin API, we should keep providing the curated API for Zipkin->pdata translation as long as we offer zipkin receiver. It's being used in the Splunk distro where we don't want diverge from the OTel specification.
dyl10s
pushed a commit
to dyl10s/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2025
This is a breaking change of this package: this struct is not used directly anywhere in contrib, and therefore it would make sense to no longer expose it. I would like to hear back if anyone is using this directly as API.
dyl10s
pushed a commit
to dyl10s/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2025
Reverts open-telemetry#43852 Given that we provide pdata->zipkin API, we should keep providing the curated API for Zipkin->pdata translation as long as we offer zipkin receiver. It's being used in the Splunk distro where we don't want diverge from the OTel specification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change of this package: this struct is not used directly anywhere in contrib, and therefore it would make sense to no longer expose it. I would like to hear back if anyone is using this directly as API.