docs(spanmetrics): Fix feature gate name in README#43626
Merged
codeboten merged 2 commits intoOct 17, 2025
Conversation
Update feature gate name from includeServiceInstanceID to includeCollectorInstanceID.
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
codeboten
approved these changes
Oct 17, 2025
Contributor
|
Thank you for your contribution @liamfd! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
ChrsMark
pushed a commit
to ChrsMark/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2025
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Hello! It looks like open-telemetry#41865 introduced a new feature flag and associated docs. The docs list it as `connector.spanmetrics.includeServiceInstanceID`, but I believe it's actually `connector.spanmetrics.includeCollectorInstanceID`. Looks like it might've changed due to feedback in the PR Passing `connector.spanmetrics.includeServiceInstanceID` resulted in the following error for me: > "Error: invalid argument "connector.spanmetrics.includeServiceInstanceID" for "--feature-gates" flag: no such feature gate "connector.spanmetrics.includeServiceInstanceID". valid gates: [awsemf.nodimrollupdefault clickhouse.json cloudfoundry.resourceAttributes.allow confighttp.framedSnappy confmap.enableMergeAppendOption connector.datadogconnector.NativeIngest connector.servicegraph.legacyLatencyMetricNames connector.servicegraph.legacyLatencyUnitMs connector.servicegraph.virtualNode connector.spanmetrics.excludeResourceMetrics connector.spanmetrics.includeCollectorInstanceID connector.spanmetrics.legacyMetricNames connector.spanmetrics.useSecondAsDefaultMetricsUnit datadog.EnableOperationAndResourceNameV2 datadog.EnableReceiveResourceSpansV2 exporter.PersistRequestContext exporter.awsxray.skiptimestampvalidation exporter.datadogexporter.DisableAPMStats exporter.datadogexporter.InferIntervalForDeltaMetrics exporter.datadogexporter.TraceExportUseCustomHTTPClient exporter.datadogexporter.UseLogsAgentExporter exporter.datadogexporter.metricexportnativeclient exporter.datadogexporter.metricexportserializerclient exporter.datadogexporter.metricremappingdisabled exporter.googlecloud.CustomMonitoredResources exporter.googlemanagedprometheus.intToDouble exporter.kafkaexporter.UseFranzGo exporter.prometheusexporter.DisableAddMetricSuffixes exporter.prometheusremotewritexporter.EnableMultipleWorkers exporter.prometheusremotewritexporter.RetryOn429 exporter.prometheusremotewritexporter.enableSendingRW2 exporter.xray.allowDot extension.jaegerremotesampling.replaceThriftWithProto extension.sumologic.updateCollectorMetadata filelog.allowFileDeletion filelog.allowHeaderMetadataParsing filelog.decompressFingerprint filelog.mtimeSortType filter.filterlog.useOTTLBridge filter.filtermetric.useOTTLBridge filter.filterspan.useOTTLBridge hostmetrics.process.bootTimeCache k8sattr.fieldExtractConfigRegex.disallow k8sattr.labelsAnnotationsSingular.allow logs.assignKeys logs.jsonParserArray metricsgeneration.MatchAttributes otelcol.printInitialConfig parser.uri.ecscompliant pdata.enableRefCounting pdata.useCustomProtoEncoding pdata.useProtoPooling pkg.translator.prometheus.NormalizeName pkg.translator.prometheus.PermissiveLabelSanitization postgresqlreceiver.preciselagmetrics processor.resourcedetection.propagateerrors processor.resourcedetection.removeGCPFaasID processor.tailsamplingprocessor.disableinvertdecisions processor.tailsamplingprocessor.metricstatcountspanssampled processor.tailsamplingprocessor.recordpolicy processor.transform.ConvertBetweenSumAndGaugeMetricContext receiver.azureeventhubreceiver.UseAzeventhubs receiver.datadogreceiver.Enable128BitTraceID receiver.hostmetricsreceiver.UseLinuxMemAvailable receiver.jaeger.DisableRemoteSampling receiver.kafkametricsreceiver.UseFranzGo receiver.kafkareceiver.UseFranzGo receiver.mongodb.removeDatabaseAttr receiver.postgresql.connectionPool receiver.postgresql.separateSchemaAttr receiver.prometheusreceiver.EnableCreatedTimestampZeroIngestion receiver.prometheusreceiver.EnableNativeHistograms receiver.prometheusreceiver.RemoveLegacyResourceAttributes receiver.prometheusreceiver.RemoveStartTimeAdjustment receiver.prometheusreceiver.UseCollectorStartTimeFallback receiver.prometheusreceiver.UseCreatedMetric receiver.sqlserver.RemoveServerResourceAttribute receiver.vcenter.resourcePoolMemoryUsageAttribute receiverhelper.newReceiverMetrics service.AllowNoPipelines service.noopTracerProvider service.profilesSupport stanza.synchronousLogEmitter telemetry.UseLocalHostAsDefaultMetricsAddress telemetry.disableHighCardinalityMetrics telemetry.newPipelineTelemetry transform.flatten.logs]" So here I just fix the name in the docs. #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> n/a #### Link to tracking issue n/a <!--Describe what testing was performed and which tests were added.--> #### Testing I copy pasted the flag name string from the doc change into my dockerfile and made sure it ran (no typos). <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Just updating `connector/spanmetricsconnector/README.md` as described above. ---- Thanks for the feature! Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! It looks like #41865 introduced a new feature flag and associated docs. The docs list it as
connector.spanmetrics.includeServiceInstanceID, but I believe it's actuallyconnector.spanmetrics.includeCollectorInstanceID. Looks like it might've changed due to feedback in the PRPassing
connector.spanmetrics.includeServiceInstanceIDresulted in the following error for me:So here I just fix the name in the docs.
Description
n/a
Link to tracking issue
n/a
Testing
I copy pasted the flag name string from the doc change into my dockerfile and made sure it ran (no typos).
Documentation
Just updating
connector/spanmetricsconnector/README.mdas described above.Thanks for the feature!