Skip to content

[chore]Fix time skew in TestLRUSetLifeTime using epsilon assertion #43146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 2 commits into from
Oct 6, 2025
Merged

[chore]Fix time skew in TestLRUSetLifeTime using epsilon assertion #43146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a50a51
[chore]Fix time skew in TestLRUSetLifeTime using epsilon assertion
lahsivjar Oct 6, 2025
da123c5
Merge branch 'main' into lrutestfix-take2
lahsivjar Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions exporter/elasticsearchexporter/internal/lru/lruset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ func TestLRUSetLifeTime(t *testing.T) {
})
require.NoError(tt, err)
assert.False(tt, val)
}, lifetime*2, lifetime/10)
assert.GreaterOrEqual(t, time.Since(timeSet), lifetime)
}, lifetime*2, lifetime/100) // tick is kept at 1% of lifetime
// Assert with epsilon to somewhat account for NTP adjustments.
// Also see: https://github.com/elastic/go-freelru/issues/1
assert.InEpsilon(t, lifetime, time.Since(timeSet), 0.015) // epsilon is kept at 1.5%
}

func BenchmarkLRUSetCheck(b *testing.B) {
Expand Down