Add JMX scraper version 1.50.0-alpha#43024
Conversation
| "e791ccfcfee9c0d299d07474d9bfcbfcbebf1181323be601220c8a823062ab99": { | ||
| version: "1.50.0-alpha", | ||
| jar: "JMX scraper", | ||
| }, | ||
| "e791ccfcfee9c0d299d07474d9bfcbfcbebf1181323be601220c8a823062ab99": { |
There was a problem hiding this comment.
Looks like the hash is wrong (duplicated)
There was a problem hiding this comment.
(cc @breedx-splk @robsunday @SylvainJuge as component owners on the Java side)
There was a problem hiding this comment.
I can confirm the hash is wrong here, it should have been d435d766b3cacc731713b95906b2204a1a4eab4ab58413163f6413573f35e0d3, as confirmed by the following command:
curl -s https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/1.50.0-alpha/opentelemetry-jmx-scraper-1.50.0-alpha.jar | sha256sum
The hash value of 1.49.0-alpha version has been reused, so maybe there is something off with the automation that generates this PR.
There was a problem hiding this comment.
I think I've found the probable cause of this duplicated hash:
- the first two versions for 1.46.0 and 1.48.0 have been added manually and are correct
- the automation uses a bogus URL, which results in a static 404 page, for which the hash is constant, hence the hash conflict.
We can get the correct hashes for 1.49.0 and 1.50.0 respectively with
curl -s https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/1.49.0-alpha/opentelemetry-jmx-scraper-1.49.0-alpha.jar|sha256sum
# b821f96df239d1e1078c0f51f07977bc375e56e92c2d96eb7954ad30e617c677 -
curl -s https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/1.50.0-alpha/opentelemetry-jmx-scraper-1.50.0-alpha.jar|sha256sum
# d435d766b3cacc731713b95906b2204a1a4eab4ab58413163f6413573f35e0d3 -The fun thing is that I found this by chance using an invalid URL when investigating this.
There was a problem hiding this comment.
I've opened #43067 to fix the URL used and 1.49.0 hash.
Once the fix is merged, closing this PR and/or re-run the automation to update would help to validate the fix is effective.
#### Description When support for the jmx-scraper component was added to the `jmxreceiver`, it was not yet available in github release assets, hence for automatic update automation it was downloaded from maven central. Unfortunately, the URL pattern for maven central artifacts was bogus and returned a 404, which in turn produced a constant hash, this failure was silent for the update to 1.49.0, at least for the CI, as any user would have not been able to use it. We can now use the github release assets URL as `jmx-scraper` artifact is now available, and thus the URL is consistent with the one used for `jmx-metrics` artifact. This was only caught when the update for 1.50.0 triggered a duplicate hash because the same 404 page was hashed and added to the dictionary in #43024. cc @rogercoll
|
Closing per the comment thread & waiting for bot to recreate it |
4 participants
Add JMX scraper version
1.50.0-alpha.cc @open-telemetry/java-contrib-approvers