receiver/statsdreceiver: fix data race in shutdown#43002
Merged
Conversation
Simplify the code, and avoid a data race by ensuring that sync.WaitGroup.Add calls always come before the sync.WaitGroup.Wait call by closing the listener first on shutdown. Fixes open-telemetry#42878
atoulme
approved these changes
Sep 26, 2025
VihasMakwana
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify the code, and avoid a data race by ensuring that sync.WaitGroup.Add calls always come before the sync.WaitGroup.Wait call by closing the listener first on shutdown.
Link to tracking issue
Fixes #42878
Testing
go test -v -failfast -run Test_Server_ListenAndServe -count=1000 -raceDocumentation
N/A