Skip to content

[chore][scoped-tests] Run twice instead of thrice #42790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 1 commit into from
Sep 19, 2025
Merged

[chore][scoped-tests] Run twice instead of thrice #42790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/scoped-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
env:
CHANGED_GOLANG_SOURCES: ${{ needs.changedfiles.outputs.go_sources }}
run: |
make for-affected-components CMD="make lint test-three-times"
make for-affected-components CMD="make lint test-twice"

scoped-tests:
# Keeps the name of the job required for merging in the GH configuration, make it
Expand Down
6 changes: 3 additions & 3 deletions Makefile.Common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ test: $(GOTESTSUM)

# This target is used in scoped tests.
# We do not pass GOTESTSUM_OPT so that we do not re-run failures
# and run each changed test three times.
# and run each changed test two times.
#
# This helps us catch flakes more easily before they land on main.
test-three-times: $(GOTESTSUM)
$(GOTESTSUM) --packages="./..." -- $(GOTEST_OPT) -count=3
test-twice: $(GOTESTSUM)
$(GOTESTSUM) --packages="./..." -- $(GOTEST_OPT) -count=2

.PHONY: test-with-cover
test-with-cover: $(GOTESTSUM)
Expand Down
Loading