Skip to content

[chore][exporter/prometheusremotewrite] Use os.MktempDir on Windows to avoid error during cleanup #42635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 4 commits into from
Sep 11, 2025
Merged

[chore][exporter/prometheusremotewrite] Use os.MktempDir on Windows to avoid error during cleanup #42635

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b944c1
[chore][test] Add a comment in prw exporter tests to trigger scoped t…
mx-psi Sep 11, 2025
661ee34
Try to create the temporary directory but not remove it
mx-psi Sep 11, 2025
74aa9d7
Add issue number and scope change to Windows
mx-psi Sep 11, 2025
4a68756
Revert "[chore][test] Add a comment in prw exporter tests to trigger …
mx-psi Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion exporter/prometheusremotewriteexporter/exporter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import (
"net/http"
"net/http/httptest"
"net/url"
"os"
"runtime"
"strconv"
"strings"
"sync"
Expand Down Expand Up @@ -757,8 +759,18 @@ func Test_PushMetrics(t *testing.T) {
}

if useWAL {
var dir string
if runtime.GOOS == "windows" {
// On Windows, use os.MkdirTemp to create directory since t.TempDir results in an error during cleanup in scoped-tests.
// See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/42639
var err error
dir, err = os.MkdirTemp("", tt.name) //nolint:usetesting
require.NoError(t, err)
} else {
dir = t.TempDir()
}
cfg.WAL = configoptional.Some(WALConfig{
Directory: t.TempDir(),
Directory: dir,
})
}

Expand Down
Loading