[exporter/awsxrayexporter] fix messaging system logic#42633
Merged
mx-psi merged 9 commits intoOct 6, 2025
Conversation
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
github-actions
Bot
added
first-time contributor
wangzlei
reviewed
Sep 17, 2025
Contributor
wangzlei
left a comment
wangzlei
left a comment
There was a problem hiding this comment.
LGTM.
literally, consumer span is the local root span, should be translated to xray Segment instead of Subsegment.
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
wangzlei
approved these changes
Sep 18, 2025
Contributor
|
@TylerHelmuth Please help merge the PR, thanks! |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
approved these changes
Oct 6, 2025
Contributor
|
Thank you for your contribution @ezhang6811! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Oct 6, 2025
…#42633) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Set `namespace="remote"` for producer spans so that X-ray will infer a downstream service node. Changed consumer spans to be segments so that they can correlate to their own node while being downstream from the producer. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40995 <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests for producer span and updated unit tests for consumer spans. <!--Please delete paragraphs that you did not use before submitting.-->
thpierce
pushed a commit
to thpierce/opentelemetry-collector-contrib
that referenced
this pull request
Oct 6, 2025
…#42633) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Set `namespace="remote"` for producer spans so that X-ray will infer a downstream service node. Changed consumer spans to be segments so that they can correlate to their own node while being downstream from the producer. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40995 <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests for producer span and updated unit tests for consumer spans. <!--Please delete paragraphs that you did not use before submitting.-->
sky333999
pushed a commit
to amazon-contributing/opentelemetry-collector-contrib
that referenced
this pull request
Oct 6, 2025
mashhurs
pushed a commit
to mashhurs/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…#42633) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Set `namespace="remote"` for producer spans so that X-ray will infer a downstream service node. Changed consumer spans to be segments so that they can correlate to their own node while being downstream from the producer. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40995 <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests for producer span and updated unit tests for consumer spans. <!--Please delete paragraphs that you did not use before submitting.-->
tommyers-elastic
pushed a commit
to tommyers-elastic/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2025
…#42633) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Set `namespace="remote"` for producer spans so that X-ray will infer a downstream service node. Changed consumer spans to be segments so that they can correlate to their own node while being downstream from the producer. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40995 <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests for producer span and updated unit tests for consumer spans. <!--Please delete paragraphs that you did not use before submitting.-->
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
Apr 12, 2026
… segments Before this change, an X-Ray segment produced from a Consumer span that is a local root used the remote service name (aws.remote.service) or, if that attribute was absent, fell back to the span (operation) name. Server local root spans already used aws.local.service / resource service.name. Consumer local root spans should behave the same way now that PR open-telemetry#42633 promotes them to Segments. Changes in MakeSegment: 1. Extend the aws.local.service attribute check to also cover Consumer spans that are local roots (mirrors the existing Server logic). 2. Extend the resource.service.name fallback to also cover Consumer local root spans when neither aws.local.service nor aws.remote.service is set. Fixes open-telemetry#43432 Assisted-by: Claude Sonnet 4.6
3 tasks
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
Apr 12, 2026
… segments After PR open-telemetry#42633 promoted Consumer local root spans to X-Ray Segments, the service segment naming still fell through to the span (operation) name when aws.local.service was absent, while Server segments already fell back to resource.service.name. Fix is applied directly in MakeServiceSegmentForLocalRootDependencySpan rather than in MakeSegment, so the dependency subsegment produced alongside is unaffected regardless of whether aws.remote.service is present. Naming priority for the service segment (unchanged for all other paths): 1. aws.local.service attribute (existing behavior) 2. resource.service.name (new fallback, mirrors Server span behavior) 3. span name / other existing fallbacks Fixes open-telemetry#43432 Assisted-by: Claude Sonnet 4.6
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
May 1, 2026
… segments Before this change, an X-Ray segment produced from a Consumer span that is a local root used the remote service name (aws.remote.service) or, if that attribute was absent, fell back to the span (operation) name. Server local root spans already used aws.local.service / resource service.name. Consumer local root spans should behave the same way now that PR open-telemetry#42633 promotes them to Segments. Changes in MakeSegment: 1. Extend the aws.local.service attribute check to also cover Consumer spans that are local roots (mirrors the existing Server logic). 2. Extend the resource.service.name fallback to also cover Consumer local root spans when neither aws.local.service nor aws.remote.service is set. Fixes open-telemetry#43432 Assisted-by: Claude Sonnet 4.6
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
May 1, 2026
… segments After PR open-telemetry#42633 promoted Consumer local root spans to X-Ray Segments, the service segment naming still fell through to the span (operation) name when aws.local.service was absent, while Server segments already fell back to resource.service.name. Fix is applied directly in MakeServiceSegmentForLocalRootDependencySpan rather than in MakeSegment, so the dependency subsegment produced alongside is unaffected regardless of whether aws.remote.service is present. Naming priority for the service segment (unchanged for all other paths): 1. aws.local.service attribute (existing behavior) 2. resource.service.name (new fallback, mirrors Server span behavior) 3. span name / other existing fallbacks Fixes open-telemetry#43432 Assisted-by: Claude Sonnet 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set
namespace="remote"for producer spans so that X-ray will infer a downstream service node. Changed consumer spans to be segments so that they can correlate to their own node while being downstream from the producer.Link to tracking issue
Fixes #40995
Testing
Added unit tests for producer span and updated unit tests for consumer spans.