Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .chloggen/splunk-searchartifact-fix-typo.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: splunkenterprisereceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fix a typo from a previous PR implementing the search artifact size metrics, which has caused errors from parsing empty strings.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [42615]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
2 changes: 1 addition & 1 deletion receiver/splunkenterprisereceiver/search_result.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ type dispatchArtifactContent struct {
AdhocSize string `json:"adhoc_size_mb"`
ScheduledSize string `json:"scheduled_size_mb"`
CompletedSize string `json:"completed_size_mb"`
IncompleteSize string `json:"incomplete_size_mb"`
IncompleteSize string `json:"incomple_size_mb"`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reference to this field somewhere in the docs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, we just pull these from the splunk introspection logs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is a typo in the returned results?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field in the introspection log is "incomple_size_mb", so the typo is actually on the splunkd side. However, I think it will be easier to make the change in otel to match what we have in splunkd, since it will take a long time to get any change in splunkd rolled out to customers.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this field was not documented in the introspection docs so I doubt that its been noticed on the splunkd side. I think probably the only realistic option is to change it here to match the actual returned results.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shalper2 please approve in this case, and we can let it in.

}

// '/services/server/health/splunkd/details'
Expand Down
Loading