Skip to content

[processor/resourcedetection] run go modernize tool #42596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
songy23 merged 2 commits into from
Sep 9, 2025
Merged

[processor/resourcedetection] run go modernize tool #42596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31df13b
[processor/resourcedetection] run go modernize tool
paulojmdias Sep 9, 2025
6ff3289
chore: remove changelog
paulojmdias Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion processor/resourcedetectionprocessor/internal/resourcedetection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ func TestDetectResource_Parallel(t *testing.T) {
// call p.Get multiple times
wg := &sync.WaitGroup{}
wg.Add(iterations)
for i := 0; i < iterations; i++ {
for range iterations {
go func() {
defer wg.Done()
detected, _, err := p.Get(t.Context(), &http.Client{Timeout: 10 * time.Second})
Expand Down
12 changes: 4 additions & 8 deletions processor/resourcedetectionprocessor/resourcedetection_processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,7 @@ func benchmarkConsumeTraces(b *testing.B, cfg *Config) {
sink := new(consumertest.TracesSink)
processor, _ := factory.CreateTraces(b.Context(), processortest.NewNopSettings(metadata.Type), cfg, sink)

b.ResetTimer()
for n := 0; n < b.N; n++ {
for b.Loop() {
// TODO use testbed.PerfTestDataProvider here once that includes resources
assert.NoError(b, processor.ConsumeTraces(b.Context(), ptrace.NewTraces()))
}
Expand All @@ -324,8 +323,7 @@ func benchmarkConsumeMetrics(b *testing.B, cfg *Config) {
sink := new(consumertest.MetricsSink)
processor, _ := factory.CreateMetrics(b.Context(), processortest.NewNopSettings(metadata.Type), cfg, sink)

b.ResetTimer()
for n := 0; n < b.N; n++ {
for b.Loop() {
// TODO use testbed.PerfTestDataProvider here once that includes resources
assert.NoError(b, processor.ConsumeMetrics(b.Context(), pmetric.NewMetrics()))
}
Expand All @@ -346,8 +344,7 @@ func benchmarkConsumeLogs(b *testing.B, cfg *Config) {
sink := new(consumertest.LogsSink)
processor, _ := factory.CreateLogs(b.Context(), processortest.NewNopSettings(metadata.Type), cfg, sink)

b.ResetTimer()
for n := 0; n < b.N; n++ {
for b.Loop() {
// TODO use testbed.PerfTestDataProvider here once that includes resources
assert.NoError(b, processor.ConsumeLogs(b.Context(), plog.NewLogs()))
}
Expand All @@ -368,8 +365,7 @@ func benchmarkConsumeProfiles(b *testing.B, cfg *Config) {
sink := new(consumertest.ProfilesSink)
processor, _ := factory.(xprocessor.Factory).CreateProfiles(b.Context(), processortest.NewNopSettings(metadata.Type), cfg, sink)

b.ResetTimer()
for n := 0; n < b.N; n++ {
for b.Loop() {
// TODO use testbed.PerfTestDataProvider here once that includes resources
assert.NoError(b, processor.ConsumeProfiles(b.Context(), pprofile.NewProfiles()))
}
Expand Down
Loading