Add disable_keep_alives configuration option to Zipkin receiver#42531
Conversation
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
@evan-bradley Can you please review it? |
|
Please take a look at the lint failures: Please add a changelog |
|
Once addressed, please mark ready for review again and we will kick off the CI. |
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
Done |
| // Disabled by default | ||
| ParseStringTags bool `mapstructure:"parse_string_tags"` | ||
| // If true, HTTP keep-alive is disabled. By default, keep-alive is enabled. | ||
| DisableKeepAlives bool `mapstructure:"disable_keep_alives"` |
There was a problem hiding this comment.
why does this need to be part of zipkin config and not confighttp.ServerConfig?
There was a problem hiding this comment.
ok i now understood, after it will be added to confighttp.ServerConfig, this would make it available to all HTTP receivers not just Zipkin
There was a problem hiding this comment.
That's right, please open an issue in https://github.com/open-telemetry/opentelemetry-collector and link it here
There was a problem hiding this comment.
I actually already opened a PR for this here: open-telemetry/opentelemetry-collector#13783
Description
This PR adds support for disabling HTTP keep-alive connections in the Zipkin receiver by introducing a new
disable_keep_alivesconfiguration option.HTTP keep-alive connections can sometimes cause issues in high-load environments or when using certain load balancers. Users need the ability to disable keep-alive behavior to:
Usage Example