[receiver/k8seventsreceiver] support leader election using k8sleaderelector extension#42330
Merged
Merged
Conversation
…lector extension Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
paulojmdias
requested review from
a team,
ChrsMark,
TylerHelmuth and
dmitryax
as code owners
ChrsMark
reviewed
Sep 1, 2025
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
Thank's for working on this!
The change looks mostly good to me with a question regarding how we should handle leadership changes across all similar components for consistency+accuracy.
…-contrib into feat/42266 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
odubajDT
approved these changes
Sep 9, 2025
…-contrib into feat/42266 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…lector-contrib into feat/42266 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
ChrsMark
approved these changes
Sep 16, 2025
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
LGTM but let's ensure we are consistent on how we consume the extension in different components: #42330 (comment)
@dmitryax please take a look too
This was referenced Sep 16, 2025
Member
Author
|
@ChrsMark issues opened:
If someone can assign it to me, I really appreciate it 🙌 |
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…-contrib into feat/42266 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…-contrib into feat/42266 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…lector-contrib into feat/42266 Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
TylerHelmuth
approved these changes
Sep 26, 2025
atoulme
pushed a commit
that referenced
this pull request
Sep 28, 2025
…rmer handler (#43018) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description As discussed in the following [thread](#42330 (comment)), I decided to open a dedicated PR for this. The change just makes the code safer, as before we were assuming the object was always an Event, which could panic if it wasn’t. Now we check first, and skip anything that isn’t an Event. Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
atoulme
pushed a commit
that referenced
this pull request
Sep 30, 2025
…e is lost (#43054) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Similar to what we did in #42330, this PR ensures similarity and puts the receiver in stand-by instead of shutdown when `k8sleaderelector` is used. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #42706 <!--Describe what testing was performed and which tests were added.--> #### Testing Tested locally, and tests were not changed to ensure the current receiver is not affected at all. <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding support for leader election using
k8sleaderelectorextension.Link to tracking issue
Fixes #42266
Testing
Added the test
TestReceiverWithLeaderElection.I'm just missing testing it in a real scenario, but I will do it next week. However, I marked it as ready for review for discussing the logic and structure 🙏
Documentation
Updated README.md with the example of how it can be used.