Skip to content

[exporter/opensearch] Add bodymap mode support for logs to opensearch exporter#42206

Merged
songy23 merged 7 commits into
open-telemetry:mainfrom
flomedja:support-bodymap-mapping-mode-for-opensearch
Sep 26, 2025
Merged

[exporter/opensearch] Add bodymap mode support for logs to opensearch exporter#42206
songy23 merged 7 commits into
open-telemetry:mainfrom
flomedja:support-bodymap-mapping-mode-for-opensearch

Conversation

@flomedja
Copy link
Copy Markdown
Contributor

@flomedja flomedja commented Aug 22, 2025 •
edited
Loading

Description

Add support for bodymap for opensearch exporter

Link to tracking issue

#41654

Testing

Add unit tests for the bodymap mode

Documentation

@flomedja flomedja requested a review from a team as a code owner August 22, 2025 23:50
@flomedja flomedja requested a review from mx-psi August 22, 2025 23:50
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Aug 22, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@flomedja flomedja force-pushed the support-bodymap-mapping-mode-for-opensearch branch 3 times, most recently from cefc801 to b548c26 Compare August 23, 2025 00:00
@flomedja
Copy link
Copy Markdown
Contributor Author

flomedja commented Aug 23, 2025

@ps48 Here is the MR :)

@flomedja flomedja changed the title Add bodymap mode support for logs to opensearch exporter [exporter/opensearch] Add bodymap mode support for logs to opensearch exporter Aug 25, 2025
@flomedja flomedja force-pushed the support-bodymap-mapping-mode-for-opensearch branch 4 times, most recently from 400de7d to 72c8af7 Compare August 26, 2025 16:26
@flomedja flomedja force-pushed the support-bodymap-mapping-mode-for-opensearch branch from 72c8af7 to 02d1a9f Compare August 27, 2025 00:13
ps48
ps48 reviewed Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ps48 ps48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flomedja! This will be a valuable addition to the OpenSearch exporter. I have added some minor comments on this.

Comment thread exporter/opensearchexporter/sso_log_exporter.go
Comment thread exporter/opensearchexporter/config.go
Comment thread exporter/opensearchexporter/encoder_test.go
@flomedja flomedja force-pushed the support-bodymap-mapping-mode-for-opensearch branch 2 times, most recently from 1d41655 to 81d9a98 Compare September 6, 2025 03:32
ps48
ps48 reviewed Sep 8, 2025
View reviewed changes
Comment thread exporter/opensearchexporter/README.md Outdated
@ps48
Copy link
Copy Markdown
Contributor

ps48 commented Sep 8, 2025

@mx-psi @mwear can you please help approve the workflow run here. Thanks!

@flomedja flomedja force-pushed the support-bodymap-mapping-mode-for-opensearch branch from 81d9a98 to 6ea5990 Compare September 9, 2025 02:08
@flomedja
Copy link
Copy Markdown
Contributor Author

flomedja commented Sep 10, 2025

@ps48 I suppose we ned @mx-psi approval for merging this.
I will do a subsequent MR for the separation of concern as mention in the earlier earlier :) .

atoulme
atoulme reviewed Sep 22, 2025
View reviewed changes
Comment thread exporter/opensearchexporter/encoder.go Outdated
@atoulme
Copy link
Copy Markdown
Contributor

atoulme commented Sep 22, 2025

Just a nit on the error being exported. LGTM otherwise.

@ps48
Copy link
Copy Markdown
Contributor

ps48 commented Sep 24, 2025

Hi @atoulme @songy23 Can you please help approve workflows and merge this PR?
Thanks!

@songy23 songy23 merged commit 0c5e3fc into open-telemetry:main Sep 26, 2025
185 of 186 checks passed
@github-actions github-actions Bot added this to the next release milestone Sep 26, 2025
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Sep 26, 2025

Thank you for your contribution @flomedja! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@flomedja flomedja deleted the support-bodymap-mapping-mode-for-opensearch branch December 12, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atoulme atoulme atoulme approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

+1 more reviewer

@ps48 ps48 ps48 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mwear mwear

Labels

exporter/opensearch

Projects

None yet

Milestone

v0.137.0

Development

Successfully merging this pull request may close these issues.

5 participants

@flomedja @ps48 @atoulme @mwear @songy23