[receiver/kafkareceiver] move receiver.kafkareceiver.UseFranzGo feature gate to Beta by paulojmdias · Pull Request #42181 · open-telemetry/opentelemetry-collector-contrib

paulojmdias · 2025-08-21T23:08:55Z

Description

This PR moves the receiver.kafkareceiver.UseFranzGo feature gate to Beta, as it also improves the tests to work with both libraries (sarama and franz-go) while the feature gate is enabled by default.

Link to tracking issue

Fixes #42155

Testing

Improved the tests to work with both libraries (sarama and franz-go) while the feature gate is enabled by default.

Documentation

Updated the README.md with the reference for the users to opt out of using franz-go, disabling the feature gate.

…re gate to Beta Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

axw

Thanks @paulojmdias!

The main issue is that TestComponentStatus is not really testing anything in the franz-go path: it always hits the deadline (without failing!) because we're not reporting component status.

Is that something you can look into?

paulojmdias · 2025-08-25T14:49:32Z

Thanks @paulojmdias!

The main issue is that TestComponentStatus is not really testing anything in the franz-go path: it always hits the deadline (without failing!) because we're not reporting component status.

Is that something you can look into?

Sure @axw! I'll look at all of your comments as soon as I can!

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias · 2025-08-27T11:24:06Z

@axw, I removed the featuregate tests from TestComponentStatus. I also updated the tests to support Profiles, which were added in #41479.

I tested it locally, and the tests are green, but please review it 🙏

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

axw

Looks great, thank you for iterating on it @paulojmdias!

I'm not 100% sure about the component status events we report, but same goes for Sarama. I think keeping parity is good for now, and we can revisit it alter.

I'd like to get to the bottom of #42226 before we merge this.

paulojmdias · 2025-08-28T08:10:04Z

Thank you @axw! 🙏

axw · 2025-09-25T08:51:12Z

@paulojmdias ICYMI, seems the tests are failing now. I think that since #42226 is merged, once tests are green we can mark this as ready to merge.

paulojmdias · 2025-09-25T08:59:09Z

@axw I'm looking into fixing it now 👀

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias · 2025-09-25T09:07:23Z

@axw you can look into it now.

The check-codeowners check is globally failing, but I think it is related to some token issue (maybe expiration?). I already left a Slack message for discussion.

axw

Thanks @paulojmdias. I think there's a problem with the StatusOK bit, and some possible redundant code, but otherwise it looks good.

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

axw

Thank you :)

I'm not certain if updating status on each assignment is the best, but it's along the lines of what the Sarama code is doing, and I think it's fine. Maybe we can find another way to go about it later, e.g. using franz-go's hooks.

paulojmdias · 2025-09-25T11:54:50Z

@axw Should we open an issue to revisit this later on?

axw · 2025-09-26T00:39:38Z

@paulojmdias sounds good, done: #43001

- open-telemetry#42507 - open-telemetry#42796 - open-telemetry#43105 - open-telemetry#42181 - open-telemetry#42327 - open-telemetry#42507 - open-telemetry#42796 - open-telemetry#43019 - open-telemetry#43083 - open-telemetry#43105

@paulojmdias

#### Description I would like to propose adding @paulojmdias as a code owner of the Kafka components. He has been doing excellent work across all of those components (and more besides!). - #42507 - #42796 - #43105 - #42181 - #42327 - #42507 - #42796 - #43019 - #43083 - #43105 #### Link to tracking issue N/A #### Testing N/A #### Documentation N/A

@paulojmdias

#### Description I would like to propose adding @paulojmdias as a code owner of the Kafka components. He has been doing excellent work across all of those components (and more besides!). - open-telemetry#42507 - open-telemetry#42796 - open-telemetry#43105 - open-telemetry#42181 - open-telemetry#42327 - open-telemetry#42507 - open-telemetry#42796 - open-telemetry#43019 - open-telemetry#43083 - open-telemetry#43105 #### Link to tracking issue N/A #### Testing N/A #### Documentation N/A

paulojmdias and others added 6 commits August 22, 2025 00:06

[receiver/kafkareceiver] move receiver.kafkareceiver.UseFranzGo featu…

121d72d

…re gate to Beta Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

fix: make generate

6fb2ecf

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

Merge branch 'main' into feat/42155

da5da50

fix: Update kafka_receiver_test.go

a002b19

fiz: context.Background()

f1e6eca

chore: //nolint:usetesting

09014ff

paulojmdias marked this pull request as ready for review August 22, 2025 09:58

paulojmdias requested review from a team and MovieStoreGuy as code owners August 22, 2025 09:58

github-actions Bot assigned dmitryax Aug 22, 2025

github-actions Bot added the receiver/kafka label Aug 22, 2025

github-actions Bot requested review from axw and pavolloffay August 22, 2025 09:58

Merge branch 'main' into feat/42155

a4131e8

atoulme added the waiting-for-code-owners label Aug 24, 2025

axw reviewed Aug 25, 2025

View reviewed changes

chore: update readme.md

f56fea2

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

MovieStoreGuy reviewed Aug 26, 2025

View reviewed changes

Comment thread receiver/kafkareceiver/factory_test.go Outdated

pavolloffay approved these changes Aug 26, 2025

View reviewed changes

paulojmdias and others added 2 commits August 27, 2025 00:10

feat: test and consumer improvements

be8ae76

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

Merge branch 'main' into feat/42155

060d629

axw reviewed Aug 27, 2025

View reviewed changes

Comment thread receiver/kafkareceiver/consumer_franz.go Outdated

Comment thread receiver/kafkareceiver/kafka_receiver_test.go Outdated

fix: improve tests and revert shutdown ignore cancellation

54afbbc

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias and others added 2 commits August 27, 2025 12:24

Merge branch 'main' into feat/42155

e5ddaf7

feat: add support for profiles in tests

7b7c607

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

paulojmdias mentioned this pull request Aug 27, 2025

Opportunities for performance improvements in Kafka receiver #39813

Closed

axw reviewed Aug 28, 2025

View reviewed changes

axw removed the Stale label Sep 17, 2025

Merge branch 'main' into feat/42155

0ef7943

paulojmdias and others added 2 commits September 25, 2025 09:59

Merge branch 'main' into feat/42155

4d81c8d

fix: fix tests

566350f

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

axw reviewed Sep 25, 2025

View reviewed changes

Comment thread receiver/kafkareceiver/consumer_franz.go Outdated

Comment thread receiver/kafkareceiver/consumer_franz.go Outdated

paulojmdias added 2 commits September 25, 2025 11:30

fix: improvements on signals

aacea05

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

fix: improve test for CI stability

2c468ed

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>

axw approved these changes Sep 25, 2025

View reviewed changes

axw added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels Sep 25, 2025

paulojmdias added 4 commits September 25, 2025 15:00

Merge branch 'main' into feat/42155

bda6657

Merge branch 'main' into feat/42155

f9a0d04

Merge branch 'main' into feat/42155

c33bdd0

Update consumer_franz_test.go

de4d9a1

axw mentioned this pull request Sep 26, 2025

[receiver/kafka] review component status reporting for franz-go #43001

Closed

paulojmdias added 2 commits September 26, 2025 09:57

Merge branch 'main' into feat/42155

0a21c09

Merge branch 'main' into feat/42155

de5a034

paulojmdias mentioned this pull request Sep 26, 2025

[chore][ci] only run codeowners workflow when related files are changed #42999

Merged

songy23 merged commit 0996c87 into open-telemetry:main Sep 26, 2025
185 checks passed

github-actions Bot added this to the next release milestone Sep 26, 2025

paulojmdias deleted the feat/42155 branch September 26, 2025 14:07

axw mentioned this pull request Oct 10, 2025

[chore] Add paulojmdias as a code owner #43415

Merged

Conversation

paulojmdias commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Link to tracking issue

Testing

Documentation

Uh oh!

axw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulojmdias commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulojmdias commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

axw left a comment

Choose a reason for hiding this comment

Uh oh!

paulojmdias commented Aug 28, 2025

Uh oh!

axw commented Sep 25, 2025

Uh oh!

paulojmdias commented Sep 25, 2025

Uh oh!

paulojmdias commented Sep 25, 2025

Uh oh!

axw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

axw left a comment

Choose a reason for hiding this comment

Uh oh!

paulojmdias commented Sep 25, 2025

Uh oh!

axw commented Sep 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

paulojmdias commented Aug 21, 2025 •

edited

Loading

paulojmdias commented Aug 27, 2025 •

edited

Loading