[receiver/prometheus] Add otel_scope_[attribute]#41958
Closed
heliapb wants to merge 2 commits into
Closed
Conversation
heliapb
changed the title
otel_scope_[attribute]otel_scope_[attribute]
heliapb
force-pushed
the
feat/add_otel_scope_attributes
branch
4 times, most recently
from
7118529 to
e6b4966
Compare
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
heliapb
force-pushed
the
feat/add_otel_scope_attributes
branch
from
e6b4966 to
75d2231
Compare
github-actions
Bot
added
receiver/prometheus
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
Member
|
Hey Helia, thanks for offering help here! The change is not as easy as it looks. Besides parsing scope attributes from labels prefixed with I happen to have a PR open already, do you want to take a look, try it out and maybe review? :) I totally forgot to link the PR with the issue, sorry about that |
Author
|
Hi @ArthurSens sure thing, I totally forgot to check the existing prs as well, my bad. I'll close this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
otel_scope_[attribute], from opentelemetry-go/5947Link to tracking issue
Fixes #41502
Testing
Documentation