exporter/prometheus: Implement translation strategies#41530
Conversation
|
opening as draft since tests are failing and I couldn't figure out why today... I suspect content negotiation |
|
Test is failing because actual result does not include metric value? |
|
Well that link didn't work, but that's the diff I found |
🤦 ... ok that was a problem too, but the diff also shows the metric name being escaped when it shouldn't |
ArthurSens
changed the title
Indeed it was!!! I was using |
| noTranslation translationStrategy = "NoTranslation" | ||
| ) | ||
|
|
||
| var translationStrategyFeatureGate = featuregate.GlobalRegistry().MustRegister( |
There was a problem hiding this comment.
IMO the feature gate should only control the removal of existing configuration options, and translation_strategy should always take precedence over existing conflicting options. That way someone can just migrate and doesn't need to mess with feature gates.
There was a problem hiding this comment.
hmmm, that's a good point 🤔
ArthurSens
force-pushed
the
promexporter-translation-strategies
branch
from
e291293 to
879d5e5
Compare
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
…tion Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
ArthurSens
force-pushed
the
promexporter-translation-strategies
branch
from
879d5e5 to
0a3987a
Compare
ArthurSens
added
the
ready to merge
|
Following up on #41318 (comment), I was planning on upgrading otlptranslator to latest in this PR as well, but it's probably better to do in a follow-up. It is bringing some API changes that might be confusing to review in this PR that adds a new feature |
…#41530) #### Description Implements `translation_strategy` as described in open-telemetry/opentelemetry-specification#4533 #### Link to tracking issue Fixes open-telemetry#35459 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
5 participants
Description
Implements
translation_strategyas described in open-telemetry/opentelemetry-specification#4533Link to tracking issue
Fixes #35459
Testing
Documentation