ottlprofile: Fix the handling of references to location#41466
Merged
Conversation
florianl
requested review from
a team,
TylerHelmuth,
edmocosta and
evan-bradley
as code owners
Refactor internal/logprofile so it is prepared to be used by multiple OTel Profiling signal messages, not just pprofile.Profile. As OTel Profiling signal makes heavy use of pprofile.ProfilesDictionary the various OTel Profiling signal messages need a unified way to access this information. As requested by in @TylerHelmuth in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/41256/files#r2219373368. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
force-pushed
the
refactor-logprofile
branch
from
0032aa0 to
bd98e31
Compare
Contributor
|
It looks like the CI runs into a timeout after 45m in job "collector-build". |
rockdaboot
reviewed
Jul 23, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
changed the title
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
rockdaboot
reviewed
Jul 23, 2025
TylerHelmuth
approved these changes
Jul 24, 2025
atoulme
approved these changes
Jul 24, 2025
povilasv
pushed a commit
to coralogix/opentelemetry-collector-contrib-old-fork
that referenced
this pull request
Jul 29, 2025
…ry#41466) #### Description Refactor internal/logprofile so it is prepared to be used by multiple OTel Profiling signal messages, not just pprofile.Profile. As OTel Profiling signal makes heavy use of pprofile.ProfilesDictionary the various OTel Profiling signal messages need a unified way to access this information. As requested by in @TylerHelmuth in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/41256/files#r2219373368. --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…ry#41466) #### Description Refactor internal/logprofile so it is prepared to be used by multiple OTel Profiling signal messages, not just pprofile.Profile. As OTel Profiling signal makes heavy use of pprofile.ProfilesDictionary the various OTel Profiling signal messages need a unified way to access this information. As requested by in @TylerHelmuth in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/41256/files#r2219373368. --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor internal/logprofile so it is prepared to be used by multiple OTel Profiling signal messages, not just pprofile.Profile. As OTel Profiling signal makes heavy use of pprofile.ProfilesDictionary the various OTel Profiling signal messages need a unified way to access this information.
As requested by in @TylerHelmuth in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/41256/files#r2219373368.