Skip to content

[receiver/prometheus] Do not keep attributes for scope name and version#41456

Merged
dmitryax merged 1 commit into
open-telemetry:mainfrom
dmitryax:promreceiver-drop-scope-version-name-attributes
Jul 22, 2025
Merged

[receiver/prometheus] Do not keep attributes for scope name and version#41456
dmitryax merged 1 commit into
open-telemetry:mainfrom
dmitryax:promreceiver-drop-scope-version-name-attributes

Conversation

@dmitryax
Copy link
Copy Markdown
Member

@dmitryax dmitryax commented Jul 21, 2025

otel_scope_name and otel_scope_version labels are already set to the OpenTelemetry scope name and version fields. They should not be duplicated in the datapoint attributes.

@dmitryax dmitryax requested review from a team, ArthurSens and dashpole as code owners July 21, 2025 23:50
@github-actions github-actions Bot added the receiver/prometheus Prometheus receiver label Jul 21, 2025
@github-actions github-actions Bot requested review from Aneurysm9 and krajorama July 21, 2025 23:50
`otel_scope_name` and `otel_scope_version` labels are already set to the OpenTelemetry scope name and version. They should not be duplicated in the datapoint attributes
@dmitryax dmitryax force-pushed the promreceiver-drop-scope-version-name-attributes branch from 5473cbd to d377697 Compare July 21, 2025 23:56
@dmitryax dmitryax merged commit 74a970d into open-telemetry:main Jul 22, 2025
188 checks passed
@dmitryax dmitryax deleted the promreceiver-drop-scope-version-name-attributes branch July 22, 2025 16:26
povilasv pushed a commit to coralogix/opentelemetry-collector-contrib-old-fork that referenced this pull request Jul 29, 2025
…on (open-telemetry#41456)

`otel_scope_name` and `otel_scope_version` labels are already set to the
OpenTelemetry scope name and version fields. They should not be
duplicated in the datapoint attributes.
Dylan-M pushed a commit to Dylan-M/opentelemetry-collector-contrib that referenced this pull request Aug 5, 2025
…on (open-telemetry#41456)

`otel_scope_name` and `otel_scope_version` labels are already set to the
OpenTelemetry scope name and version fields. They should not be
duplicated in the datapoint attributes.
gracewehner added a commit to Azure/prometheus-collector that referenced this pull request Aug 13, 2025
This PR upgrades the otelcollector to the latest version available for
the opentelemetry-collector and opentelemetry-operator.

It was automatically generated by the GitHub Actions workflow.

The summary of the OSS changelog is below:
# Prometheusreceiver Changes
## v0.127.0 to v0.131.0

Generated on: 2025-08-04 17:36:24

---

### v0.131.0
- [**FEATURE**] `prometheusreceiver`: Add retry logic for connection
refused errors so the collector doesn't crash at startup.
([#40982](open-telemetry/opentelemetry-collector-contrib#40982))
This change adds retry logic for connection refused errors. The target
allocator could be busy starting up the receiver and the first
connection attempt may fail.
- [**FEATURE**] `receiver/prometheus`: Add support for
otel_scope_schema_url label mapping to OpenTelemetry ScopeMetrics schema
URL field
([#41488](open-telemetry/opentelemetry-collector-contrib#41488))
- [**FEATURE**] `receiver/prometheusremotewrite`: Add support for Native
Histogram Custom Buckets (NHCB).
([#41043](open-telemetry/opentelemetry-collector-contrib#41043))
- [**BUG FIX**] `receiver/prometheus`: Fix otel_scope_name and
otel_scope_version labels not being dropped from metric attributes
([#41456](open-telemetry/opentelemetry-collector-contrib#41456))
### v0.130.0
- [**BUG FIX**] `receiver/prometheusreceiver`: Fixes masking of
authentication credentials in Prometheus receiver, when reloading the
Prometheus config.
([#40520](open-telemetry/opentelemetry-collector-contrib#40520),
[#40916](open-telemetry/opentelemetry-collector-contrib#40916))
- [**BUG FIX**] `receiver/prometheusremotewrite`: Handle metrics with
unspecified types without panicking.
([#41005](open-telemetry/opentelemetry-collector-contrib#41005))
### v0.129.0
- [**FEATURE**] `prometheusreceiver`: Promote the
receiver.prometheusreceiver.RemoveLegacyResourceAttributes featuregate
to stable
([#40572](open-telemetry/opentelemetry-collector-contrib#40572))
It has been beta since v0.126.0
- [**BUG FIX**] `prometheusreceiver`: Fix invalid metric name validation
error in scrape start from target allocator.
([#35459](open-telemetry/opentelemetry-collector-contrib#35459),
[#40788](open-telemetry/opentelemetry-collector-contrib#40788))
Prometheus made setting metric_name_validation_scheme,
metric_name_escaping_scheme mandatory mandatory, use sane defaults.

## Summary

| Category | Count |
|----------|-------|
| Breaking Changes | 0 |
| Features | 4 |
| Bug Fixes | 4 |
| Other Changes | 0 |
| **Total** | **8** |

# Target-allocator Changes
## v0.127.0 to v0.131.0

Generated on: 2025-08-04 17:36:38

---

### 0.131.0
- [**FEATURE**] `manager, target-allocator, opamp-bridge, must-gather`:
add -trimpath when building binaries
([#4078](open-telemetry/opentelemetry-operator#4078))
- [**FEATURE**] `collector, targer allocator, opamp`: Require Go 1.24+
to build the collector, target allocator, and opamp.
([#4173](open-telemetry/opentelemetry-operator#4173))
- [**BUG FIX**] `target allocator`: check CRD availability before
registering informers
([#3987](open-telemetry/opentelemetry-operator#3987))
- [**BUG FIX**] `target allocator`: Allow collector to use TLS Config
from Target Allocator with ScrapeConfig
([#3724](open-telemetry/opentelemetry-operator#3724))
This change allows the target allocator to configure TLS Config for a
collector using the ScrapeConfig.
### 0.129.1
- [**BREAKING**] `targetallocator, collector`: Remove stable feature
gate PrometheusOperatorIsAvailable
([#4141](open-telemetry/opentelemetry-operator#4141))
- [**FEATURE**] `target allocator`: Adds support for HTML output in the
target allocator.
([#3622](open-telemetry/opentelemetry-operator#3622))
- [**BUG FIX**] `target allocator`: ensure stable iteration order of
target labels when generating hash
([#4082](open-telemetry/opentelemetry-operator#4082))
- [**BUG FIX**] `target allocator`: Fix OpenShift must-gather for Target
Allocator
([#4084](open-telemetry/opentelemetry-operator#4084))

## Summary

| Category | Count |
|----------|-------|
| Breaking Changes | 1 |
| Features | 3 |
| Bug Fixes | 4 |
| Other Changes | 0 |
| **Total** | **8** |

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Grace Wehner <grace.wehner@microsoft.com>
Co-authored-by: rashmichandrashekar <rashmy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants