[exporter/elasticsearch] Create high-quality frameID if buildID is missing#41375
Merged
atoulme merged 5 commits intoJul 18, 2025
Merged
Conversation
rockdaboot
force-pushed
the
es-profiling-fix-frameid
branch
from
078853a to
c7ad8a0
Compare
rockdaboot
changed the title
carsonip
reviewed
Jul 17, 2025
christos68k
approved these changes
Jul 17, 2025
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
florianl
reviewed
Jul 18, 2025
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
florianl
approved these changes
Jul 18, 2025
carsonip
approved these changes
Jul 18, 2025
florianl
added a commit
to elastic/devfiler
that referenced
this pull request
Jul 18, 2025
Follow the idea implemented with open-telemetry/opentelemetry-collector-contrib#41375 for interpreted frames without build_id. Fixes #33 Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
added a commit
to elastic/devfiler
that referenced
this pull request
Jul 18, 2025
Follow the idea implemented with open-telemetry/opentelemetry-collector-contrib#41375 for interpreted frames without build_id. Fixes #33 Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
added a commit
to elastic/devfiler
that referenced
this pull request
Jul 18, 2025
Follow the idea implemented with open-telemetry/opentelemetry-collector-contrib#41375 for interpreted frames without build_id. Fixes #33 Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
added a commit
to elastic/devfiler
that referenced
this pull request
Jul 18, 2025
Follow the idea implemented with open-telemetry/opentelemetry-collector-contrib#41375 for interpreted frames without build_id. Fixes #33 Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
atoulme
approved these changes
Jul 18, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…ssing (open-telemetry#41375) #### Description This PR fixes an issue where a missing buildID results in low-quality frame IDs, that make collisions (same frame ID for different frames) very likely. The change generates high-quality frame IDs from the Line entries of the Location (file name, function name, line number and column). --------- Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co> Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where a missing buildID results in low-quality frame IDs, that make collisions (same frame ID for different frames) very likely.
The change generates high-quality frame IDs from the Line entries of the Location (file name, function name, line number and column).