Deprecate Batcher and configure QueueBatch with Partitioner#41373
Merged
Conversation
lahsivjar
commented
Jul 17, 2025
carsonip
reviewed
Jul 18, 2025
carsonip
reviewed
Jul 21, 2025
Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
carsonip
approved these changes
Jul 21, 2025
simitt
reviewed
Jul 21, 2025
simitt
reviewed
Jul 22, 2025
simitt
approved these changes
Jul 23, 2025
carsonip
approved these changes
Jul 23, 2025
JaredTan95
approved these changes
Jul 29, 2025
Member
Author
|
@ArthurSens The PR is reviewed by code-owners, could we mark this ready to merge now? |
edmocosta
reviewed
Jul 31, 2025
Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
edmocosta
approved these changes
Aug 1, 2025
edmocosta
added
ready to merge
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…emetry#41373) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Deprecates the `batcher` config in favour of `sending_queue#batch` and introduces a partitioner based on the configured `metadata_keys`. Note that with batcher enabled, the values in the context will not be forwarded to the exporter's callback functions due to open-telemetry/opentelemetry-collector#13320 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#41338 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests added <!--Describe the documentation added.--> #### Documentation Documentation updated <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Carson Ip <carsonip@users.noreply.github.com> Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates the
batcherconfig in favour ofsending_queue#batchand introduces a partitioner based on the configuredmetadata_keys. Note that with batcher enabled, the values in the context will not be forwarded to the exporter's callback functions due to open-telemetry/opentelemetry-collector#13320Link to tracking issue
Fixes #41338
Testing
Unit tests added
Documentation
Documentation updated