[exporter/elasticsearch] Update batcher config to adopt changes in core#41225
Merged
Conversation
dmitryax
force-pushed
the
update-elastic-exporter
branch
from
deccbc6 to
4fc12ea
Compare
axw
reviewed
Jul 10, 2025
axw
approved these changes
Jul 10, 2025
axw
left a comment
axw
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking care of this, LGTM.
dmitryax
force-pushed
the
update-elastic-exporter
branch
from
4fc12ea to
35ee875
Compare
Adopt to open-telemetry#39961 to unblock the core dependency upgrade
dmitryax
force-pushed
the
update-elastic-exporter
branch
from
35ee875 to
7e091e2
Compare
andrzej-stencel
approved these changes
Jul 10, 2025
carsonip
reviewed
Jul 10, 2025
| // to ensure sending data to the background workers will not block indefinitely. | ||
| opts = append(opts, exporterhelper.WithTimeout(exporterhelper.TimeoutConfig{Timeout: 0})) | ||
| } | ||
| opts = append(opts, exporterhelper.WithQueue(qs)) |
Contributor
There was a problem hiding this comment.
if you do
if err := qs.Validate(); err != nil {
panic("invalid config " + err.Error())
}
it is failing with
`batch` supports only `items` or `bytes` sizer`
which is what's failing integration tests. We did not validate our manually transformed config and this misconfiguration causes batcher to fail.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
carsonip
approved these changes
Jul 10, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…re (open-telemetry#41225) Adopt to open-telemetry/opentelemetry-collector#13338 to unblock the core dependency upgrade For the end user, everything stays as is for now. Going forward, the `batcher` section should be deprecated and removed. See open-telemetry#41224 as an example. I'm leaving that part to the code owners. --------- Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt to open-telemetry/opentelemetry-collector#13338 to unblock the core dependency upgrade
For the end user, everything stays as is for now. Going forward, the
batchersection should be deprecated and removed. See #41224 as an example. I'm leaving that part to the code owners.