metricstarttimeprocessor: keep keys with empty values when hashing#41050
Merged
Conversation
dashpole
added
Skip Changelog
dashpole
force-pushed
the
keep_empty_value_attrs
branch
from
0963401 to
7a237e8
Compare
dashpole
added
the
ready to merge
songy23
approved these changes
Jul 11, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…pen-telemetry#41050) #### Description Use standard collector pdata hashing functions when hashing attributes instead of removing attributes with empty values. Translation from Prometheus already removes empty values (because prometheus treats empty the same as non-existent). #### Link to tracking issue Fixes open-telemetry#38621 #### Testing N/A #### Documentation N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use standard collector pdata hashing functions when hashing attributes instead of removing attributes with empty values. Translation from Prometheus already removes empty values (because prometheus treats empty the same as non-existent).
Link to tracking issue
Fixes #38621
Testing
N/A
Documentation
N/A