[receiver/github] add repository custom properties as resource attributes#40878
Merged
mx-psi merged 22 commits intoJul 14, 2025
Conversation
krzko
changed the title
krzko
changed the title
adrielp
reviewed
Jul 3, 2025
adrielp
reviewed
Jul 3, 2025
adrielp
suggested changes
Jul 3, 2025
adrielp
left a comment
adrielp
left a comment
Member
There was a problem hiding this comment.
Overall, looks pretty good. Appreciate the addition of the tests. I left a couple nits and a suggestion around end-user documentation so that it's very clear to the end user how their custom properties are going to show up.
Contributor
Author
Not a problem at all. I updated the change log gen and added a readme update about the functionality of the custom prooperties generation as well. |
Member
|
Let's fix the test failures. A lot of the linting/testing can be run locally with |
Contributor
Author
|
Fixed up the linting, formatting issues on top of the golden file tests as well. |
adrielp
reviewed
Jul 10, 2025
adrielp
reviewed
Jul 10, 2025
adrielp
reviewed
Jul 10, 2025
…rzko/opentelemetry-collector-contrib into feat-receiver-github-custom-properties
adrielp
approved these changes
Jul 11, 2025
krzko
changed the title
mx-psi
approved these changes
Jul 14, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…utes (open-telemetry#40878) #### Description This PR enhances the GitHub receiver by adding support for custom properties from GitHub repositories as resource attributes. The implementation extracts all key-value pairs from the repository's `CustomProperties` map and adds them as resource attributes with the prefix `github.repository.custom_properties`. For example, if a repository has custom properties like `team_name: "open-telemetry"` and `environment: "development"`, they will be added as resource attributes: ``` github.repository.custom_properties.team_name = "open-telemetry" github.repository.custom_properties.environment = "development" ``` The implementation handles different value types (string, int, float, bool) appropriately and follows the OpenTelemetry convention for attribute naming, similar to how HTTP headers are handled. #### Link to tracking issue Fixes: TBD #### Testing Added unit tests for the new functionality in `model_test.go`. The tests verify: * String properties are correctly added as resource attributes * Different types (string, int, float, bool) are handled correctly * The "service_name" property is skipped (as it's handled separately) * Empty and nil maps are handled properly All tests are passing, confirming the implementation works as expected. #### Documentation TBD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the GitHub receiver by adding support for custom properties from GitHub repositories as resource attributes. The implementation extracts all key-value pairs from the repository's
CustomPropertiesmap and adds them as resource attributes with the prefixgithub.repository.custom_properties.For example, if a repository has custom properties like
team_name: "open-telemetry"andenvironment: "development", they will be added as resource attributes:The implementation handles different value types (string, int, float, bool) appropriately and follows the OpenTelemetry convention for attribute naming, similar to how HTTP headers are handled.
Link to tracking issue
Fixes: TBD
Testing
Added unit tests for the new functionality in
model_test.go. The tests verify:All tests are passing, confirming the implementation works as expected.
Documentation
TBD