[chore] [pkg/ottl] Introduce ctxutil.GetMap() and ctxutil.GetMapKeyName() internal functions#39952
Merged
Merged
Conversation
rockdaboot
changed the title
ctxutil.GetMap() and ctxutil.GetMapKeyName()ctxutil.GetMap() and ctxutil.GetMapKeyName() internal functions
edmocosta
reviewed
May 19, 2025
Contributor
edmocosta
left a comment
edmocosta
left a comment
There was a problem hiding this comment.
Thanks for working on it and for adding the extra tests :)
I've left a few suggestions for your consideration.
edmocosta
reviewed
May 20, 2025
edmocosta
approved these changes
May 21, 2025
Contributor
edmocosta
left a comment
edmocosta
left a comment
There was a problem hiding this comment.
Thank you for working on that! LGTM!
Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
Contributor
|
@TylerHelmuth @evan-bradley, could you please review this PR whenever you get the chance? |
Contributor
|
I think we're good to merge this one, it shouldn't affect existing behavior and is currenlty holding #39681 back. If needed, we can address any concern folks might have in a following PR. Thanks! |
edmocosta
added
ready to merge
rockdaboot
added a commit
to rockdaboot/opentelemetry-collector-contrib
that referenced
this pull request
Jun 10, 2025
…yName()` internal functions (open-telemetry#39952) These functions have been requested [here](open-telemetry#39681 (comment)) and [here](open-telemetry#39681 (comment)) as prerequisite for OTTL attributes accessors for the profiles signal. Also adds tests for `GetMap()`, that were missing. Unit tests --------- Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…yName()` internal functions (open-telemetry#39952) #### Description These functions have been requested [here](open-telemetry#39681 (comment)) and [here](open-telemetry#39681 (comment)) as prerequisite for OTTL attributes accessors for the profiles signal. Also adds tests for `GetMap()`, that were missing. #### Testing Unit tests --------- Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These functions have been requested here and here as prerequisite for OTTL attributes accessors for the profiles signal.
Also adds tests for
GetMap(), that were missing.Testing
Unit tests