Skip to content

[chore][pkg/ottl] Add profile to the infer priorities#39612

Merged
TylerHelmuth merged 2 commits into
open-telemetry:mainfrom
rockdaboot:fix-ottl-profile-inferring
Apr 29, 2025
Merged

[chore][pkg/ottl] Add profile to the infer priorities#39612
TylerHelmuth merged 2 commits into
open-telemetry:mainfrom
rockdaboot:fix-ottl-profile-inferring

Conversation

@rockdaboot
Copy link
Copy Markdown
Contributor

Description

Without this, inferring doesn't work. Ran into this while working on adding profiles support for the tranformprocessor.

For example, this error will be fixed with this PR:

unable to parse OTTL statement "set(profile.attributes[\"test\"], \"pass\") where resource.attributes[\"test\"] == \"pass\"": error while parsing arguments for call to "set": invalid argument at position 0: context "profile" from path "profile.attributes[test]" is not valid, it must be replaced by one of: "resource"

@rockdaboot rockdaboot marked this pull request as ready for review April 24, 2025 10:10
@github-actions github-actions Bot requested a review from kentquirk April 24, 2025 10:10
Copy link
Copy Markdown
Contributor

@edmocosta edmocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the tests so it includes and validates the new profile context order? Thanks!

@rockdaboot
Copy link
Copy Markdown
Contributor Author

Could you please update the tests so it includes and validates the new profile context order? Thanks!

👍 added the tests

@TylerHelmuth TylerHelmuth merged commit 9744752 into open-telemetry:main Apr 29, 2025
173 checks passed
@github-actions github-actions Bot added this to the next release milestone Apr 29, 2025
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 6, 2025
…#39612)

#### Description
Without this, inferring doesn't work. Ran into this while working on
adding profiles support for the tranformprocessor.

For example, this error will be fixed with this PR:
```
unable to parse OTTL statement "set(profile.attributes[\"test\"], \"pass\") where resource.attributes[\"test\"] == \"pass\"": error while parsing arguments for call to "set": invalid argument at position 0: context "profile" from path "profile.attributes[test]" is not valid, it must be replaced by one of: "resource"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants