-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[receiver/faroreceiver] Add Faro receiver logic to wireframe #39588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0940c82
[receiver/faroreceiver] Add Faro receiver logic to wireframe
t00mas ac84ddd
minor README.md fix
t00mas 9ff9a35
update go.[mod|sum]
t00mas 648c87e
update go.[mod|sum]
t00mas aae5470
make goporto
t00mas e365bf2
lint / headers
t00mas 1c07762
add changelog yaml
t00mas dda340f
make crosslink
t00mas cad3a00
lint
t00mas 7fe0d46
remove unused
t00mas fcea864
go mod tidy
t00mas ced59c4
make crosslink & go mod tidy
t00mas f72b2e6
review comments & lints
t00mas 8d3979d
remove deprecated config in tests
t00mas 14d2380
lint
t00mas 454261f
go mod tidy again
t00mas aacbac1
collector module version update
t00mas 2c7a0dc
collector module versions & go mod tidy
t00mas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
| component: faroreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Completes the implementation of the Faro receiver. | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| issues: [19180] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | ||
|
|
||
| # If your change doesn't affect end users or the exported elements of any package, | ||
| # you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
| # Optional: The change log or logs in which this entry should be included. | ||
| # e.g. '[user]' or '[user, api]' | ||
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package faroreceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/faroreceiver" | ||
|
|
||
| import ( | ||
| "path/filepath" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "go.opentelemetry.io/collector/config/confighttp" | ||
| "go.opentelemetry.io/collector/config/configtls" | ||
| "go.opentelemetry.io/collector/confmap/confmaptest" | ||
| ) | ||
|
|
||
| func TestUnmarshalDefaultConfig(t *testing.T) { | ||
| cm, err := confmaptest.LoadConf(filepath.Join("testdata", "empty.yaml")) | ||
| require.NoError(t, err) | ||
| factory := NewFactory() | ||
| cfg := factory.CreateDefaultConfig() | ||
| require.NoError(t, cm.Unmarshal(&cfg)) | ||
| assert.Equal(t, factory.CreateDefaultConfig(), cfg) | ||
| } | ||
|
|
||
| func TestUnmarshalConfig(t *testing.T) { | ||
| cm, err := confmaptest.LoadConf(filepath.Join("testdata", "config.yaml")) | ||
| require.NoError(t, err) | ||
| factory := NewFactory() | ||
| cfg := factory.CreateDefaultConfig() | ||
| require.NoError(t, cm.Unmarshal(&cfg)) | ||
| assert.Equal(t, | ||
| &Config{ | ||
| ServerConfig: confighttp.ServerConfig{ | ||
| Endpoint: "localhost:8080", | ||
| TLSSetting: &configtls.ServerConfig{ | ||
| Config: configtls.Config{ | ||
| CertFile: "test.crt", | ||
| KeyFile: "test.key", | ||
| }, | ||
| }, | ||
| CORS: &confighttp.CORSConfig{ | ||
| AllowedOrigins: []string{"https://*.test.com", "https://test.com"}, | ||
| MaxAge: 7200, | ||
| }, | ||
| }, | ||
| }, cfg) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is incorrect. his should be something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'm not even sure the cors implementation works at all. Both the config I've posted above and the example in the readme do not change the cors response headers.