[chore] Remove usages of extensionauthtest.MockClient#38401
Merged
mx-psi merged 2 commits intoMar 5, 2025
Conversation
github-actions
Bot
added
exporter/elasticsearch
receiver/sshcheck
receiver/tcpcheck
labels
github-actions
Bot
requested review from
JaredTan95,
atoulme,
carsonip,
chengchuanpeng,
lahsivjar,
michael-burt and
nslaughter
atoulme
approved these changes
Mar 5, 2025
github-merge-queue Bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 6, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Removes `extensionauthtest.MockClient`. Users can use either `extensionauth.NewClient` or use `extensionauthtest.NewErrorClient` as a convenience method to replicate the `MustError` field behavior. Doing a Github search, I am unable to find usages of this outside of contrib, which I dealt with on PR open-telemetry/opentelemetry-collector-contrib/pull/38401, thus I believe this should be fine to remove in one go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All usages of
extensionauthtest.MockClientcan be replaced by a simpleextensionauth.NewClient+ passing the appropriate options.There is one use case that is maybe useful to have a helper for: errors, which are used in
confighttptests.This PR removes usages of
extensionauthtest.MockClientso that we can remove theMockClientand replace it with something that allows for a sealed interface/struct forextensionauth.Client