Skip to content

feat: Add faro receiver#38224

Closed
dark0dave wants to merge 1 commit into
open-telemetry:mainfrom
dark0dave:feature/faro
Closed

feat: Add faro receiver#38224
dark0dave wants to merge 1 commit into
open-telemetry:mainfrom
dark0dave:feature/faro

Conversation

@dark0dave
Copy link
Copy Markdown
Contributor

@dark0dave dark0dave commented Feb 26, 2025 •
edited by atoulme
Loading

Add a faro receiver from grafana's code base.

Description

Add faro receiver #19180

Link to tracking issue

Fixes #19180

Testing

Documentation

@dark0dave dark0dave requested a review from a team as a code owner February 26, 2025 14:52
@dark0dave dark0dave requested a review from dehaansa February 26, 2025 14:52
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Feb 26, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dark0dave / name: dark0dave (f1f21ca)

@dark0dave dark0dave force-pushed the feature/faro branch 8 times, most recently from 49dfbd2 to f1d837a Compare February 26, 2025 17:33
@dark0dave dark0dave changed the title Draft: feat: Add faro reciever feat: Add faro reciever Feb 26, 2025
@atoulme atoulme added the Sponsor Needed New component seeking sponsor label Feb 27, 2025
@github-actions github-actions Bot added the cmd/otelcontribcol otelcontribcol command label Feb 28, 2025
@dark0dave dark0dave force-pushed the feature/faro branch 3 times, most recently from 6c75fd6 to 59990cb Compare February 28, 2025 15:55
@dark0dave
Copy link
Copy Markdown
Contributor Author

dark0dave commented Feb 28, 2025

@dehaansa , I have this running locally, I am just missing a sponsor
image

@dehaansa
Copy link
Copy Markdown
Contributor

dehaansa commented Feb 28, 2025

@dehaansa , I have this running locally, I am just missing a sponsor

Thanks! I'll start to take a look. I believe the original issue raiser @rlankfo is OOO this week, and I'm interested in getting their feedback as well, but I'll mark myself as a sponsor.

@dehaansa dehaansa added Accepted Component New component has been sponsored and removed Sponsor Needed New component seeking sponsor labels Feb 28, 2025
@dehaansa
Copy link
Copy Markdown
Contributor

dehaansa commented Mar 1, 2025 •
edited
Loading

I'm happy to review initially here, but forgot to mention - the preferred way to contribute a new component is in parts. First up is a wireframe of the receiver, similar to this active PR.

See docs in the CONTRIBUTING guide for details of what each PR should include.

dehaansa
dehaansa reviewed Mar 1, 2025
View reviewed changes
Comment thread receiver/faroreceiver/README.md Outdated
Comment thread receiver/faroreceiver/README.md Outdated
Comment thread receiver/faroreceiver/factory.go Outdated
Comment thread receiver/faroreceiver/internal/metadata/status.go Outdated
Comment thread receiver/faroreceiver/receiver.go Outdated
Comment thread receiver/faroreceiver/receiver.go
Comment thread receiver/faroreceiver/receiver.go Outdated
Comment thread receiver/faroreceiver/receiver.go Outdated
Comment thread receiver/faroreceiver/receiver_test.go
@dark0dave
Copy link
Copy Markdown
Contributor Author

dark0dave commented Mar 1, 2025

I'm happy to review initially here, but forgot to mention - the preferred way to contribute a new component is in parts. First up is a wireframe of the receiver, similar to this active PR.

See docs in the CONTRIBUTING guide for details of what each PR should include.

How would you like me to proceed? Should I add the wireframe in a separate pr or continue here?

Thank you for your guidance!

@dark0dave dark0dave force-pushed the feature/faro branch 4 times, most recently from 6c18df8 to 983990f Compare March 1, 2025 15:48
@dark0dave dark0dave force-pushed the feature/faro branch 3 times, most recently from 714f8e8 to 2fa2002 Compare March 4, 2025 11:35
@dark0dave
Copy link
Copy Markdown
Contributor Author

dark0dave commented Mar 4, 2025

Hey! Thank you for moving faro receiver component from the grafana/faro repo. Could you please add @rlankfo, @t00mas and @mar4uk to the code owners list?

2025/03/04 11:30:09 codeowners are not members: t00mas

@dark0dave dark0dave force-pushed the feature/faro branch 2 times, most recently from ceba8c1 to fd5a3c5 Compare March 4, 2025 11:47
@dark0dave dark0dave mentioned this pull request Mar 4, 2025
Merged
atoulme pushed a commit that referenced this pull request Mar 5, 2025
@dark0dave
feat(faro-1): Wireframe for faro receiver (#38345)
96d757d 
Signed-off-by: dark0dave <dark0dave@mykolab.com>

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
#19180

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

Related: #38224

Signed-off-by: dark0dave <dark0dave@mykolab.com>
@atoulme atoulme changed the title feat: Add faro reciever feat: Add faro receiver Mar 7, 2025
@atoulme atoulme marked this pull request as draft March 17, 2025 21:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Apr 1, 2025
@dehaansa
Copy link
Copy Markdown
Contributor

dehaansa commented Apr 1, 2025

@dark0dave 👋 the faro translator has been merged in, so it should be relatively straightforward to move forward with the rest of the receiver. Are you still interested in pursuing this component?

@github-actions github-actions Bot removed the Stale label Apr 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Apr 16, 2025
@mar4uk
Copy link
Copy Markdown
Contributor

mar4uk commented Apr 16, 2025

@dark0dave would you like to send a PR to add faro receiver logic? If not, we plan to take care of it next week

@github-actions github-actions Bot removed the Stale label Apr 17, 2025
@t00mas t00mas mentioned this pull request Apr 23, 2025
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label May 2, 2025
@abbiesims
Copy link
Copy Markdown

abbiesims commented May 15, 2025

Hi @dark0dave, is there any update on this?

@mar4uk
Copy link
Copy Markdown
Contributor

mar4uk commented May 15, 2025 •
edited
Loading

Faro receiver was implemented here, it will be available in the otelcol contrib distribution starting v0.127.0.

This PR can be closed

@github-actions github-actions Bot removed the Stale label May 16, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label May 31, 2025
@dehaansa
Copy link
Copy Markdown
Contributor

dehaansa commented Jun 2, 2025

Faro receiver implemented in #39588 as noted above, closing.

@dehaansa dehaansa closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dehaansa dehaansa dehaansa left review comments

Assignees

@crobert-1 crobert-1

Labels

Accepted Component New component has been sponsored cmd/otelcontribcol otelcontribcol command Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New component: Faro Receiver

6 participants

@dark0dave @dehaansa @mar4uk @abbiesims @atoulme @crobert-1