[chore] Update otelcol core dependency#38214
Conversation
01b77c2 to
963fe88
Compare
|
Converting into draft since the test can be fixed in core first to avoid unnecessary breaking change open-telemetry/opentelemetry-collector#12496 |
| replaces: | ||
| - go.opentelemetry.io/collector/extension/extensionauth => go.opentelemetry.io/collector/extension/extensionauth v0.0.0-20250226024140-8099e51f9a77 | ||
| - go.opentelemetry.io/collector/extension/extensionauth/extensionauthtest => go.opentelemetry.io/collector/extension/extensionauth/extensionauthtest v0.0.0-20250226024140-8099e51f9a77 | ||
| - go.opentelemetry.io/collector/service/hostcapabilities => go.opentelemetry.io/collector/service/hostcapabilities v0.0.0-20250226024140-8099e51f9a77 |
There was a problem hiding this comment.
cc @mx-psi as the next releaser. These replaces need to be removed once these modules are released.
Currently, they are referenced by v0.0.0-00010101000000-000000000000 and v0.120.0 versions in core, which are invalid. So I've put replaces here instead of trying to fix it in core which would require a few commits pointing to versions from parent commits
| FlushTimeout: 30 * time.Second, | ||
| MinSizeConfig: exporterbatcher.MinSizeConfig{ | ||
| MinSizeItems: 5000, | ||
| MinSizeConfig: exporterbatcher.MinSizeConfig{ //nolint:staticcheck |
There was a problem hiding this comment.
cc @carsonip, @lahsivjar, @axw. I'v'e added the nolint pragmas instead of migrating to the new interface because this exporter has its own BatcherConfig. Please address this separately. See open-telemetry/opentelemetry-collector#12303 and open-telemetry/opentelemetry-collector#12486
There was a problem hiding this comment.
Thanks for the ping, will look into it soon.
songy23
left a comment
There was a problem hiding this comment.
You may have missed out genoteltestbedcol, testbed has been broken since this PR https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13551275104/job/37875212771
| replaces: | ||
| - go.opentelemetry.io/collector/extension/extensionauth => go.opentelemetry.io/collector/extension/extensionauth v0.0.0-20250226024140-8099e51f9a77 | ||
| - go.opentelemetry.io/collector/extension/extensionauth/extensionauthtest => go.opentelemetry.io/collector/extension/extensionauth/extensionauthtest v0.0.0-20250226024140-8099e51f9a77 | ||
| - go.opentelemetry.io/collector/service/hostcapabilities => go.opentelemetry.io/collector/service/hostcapabilities v0.0.0-20250226024140-8099e51f9a77 |
There was a problem hiding this comment.
hmm weird that these work for make otelcontribcol but make oteltestbedcol failed
To fix contrib tests in core
Had to add replaces to the new modules to use latest main commit:
Can be removed once they are released