[chore][pkg/ottl] Move MetricPathGetSetter into ctxmetric#38184
Merged
evan-bradley merged 1 commit intoFeb 25, 2025
Conversation
github-actions
Bot
requested review from
TylerHelmuth,
bogdandrutu,
edmocosta,
evan-bradley and
kentquirk
TylerHelmuth
approved these changes
Feb 25, 2025
evan-bradley
approved these changes
Feb 25, 2025
djaglowski
added a commit
that referenced
this pull request
Feb 25, 2025
Follows pattern established in #38184
This was referenced Feb 25, 2025
djaglowski
added a commit
that referenced
this pull request
Feb 26, 2025
Follows pattern established in #38184 Note: this does not yet move `event_index` into ctxspanevent. This field seems to break the pattern so will require additional consideration of how to handle it. For now, it remains handled in the ottlspanevent package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just moves the MetricPathGetSetter into the new ctxmetric package, and renames exported elements accordingly.
I'll pursue this pattern with the other contexts if this looks good.