You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SQL Server docker users may run into an issue that the collector fails to parse certificate from server due to x509: negative serial number. That's because we adopted Go 1.23 starting from contrib v0.121.0:
Before Go 1.23, ParseCertificate accepted certificates with negative serial numbers.
This behavior can be restored by including "x509negativeserial=1" in the GODEBUG environment variable.
This change is actually not in the release notes of Go 1.23.
Since the SQL Server receiver uses the underlying scraperhelper dependency (which raises negative serial number issue) in core repo, should we consider adding a note at the project level?
This change is actually not in the release notes of Go 1.23. Since the SQL Server receiver uses the underlying scraperhelper dependency (which raises negative serial number issue) in core repo, should we consider adding a note at the project level?
So this raises an interesting question, do we raise a breaking change for each component that would be using the impacted package, or raise it a breaking change for the project.
I'll delegate that to @open-telemetry/collector-approvers to see what they say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SQL Server receiver now requires a positive serial number for X509 certificates due to the Go
1.23adoption in #38099Link to tracking issue
n/a
Testing
n/a
Documentation
n/a