Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interval): Don't send empty metrics downstream #37911

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(interval): Don't send empty metrics downstream #37911

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41bed81
fix(interval): Don't send empty metrics downstream
RichieSams Feb 13, 2025
81ec83b
Make sure the default entry is empty
RichieSams Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions processor/intervalprocessor/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,11 @@ func (p *Processor) ConsumeMetrics(ctx context.Context, md pmetric.Metrics) erro
return rm.ScopeMetrics().Len() == 0
})

// Don't send empty metrics downstream
if md.ResourceMetrics().Len() == 0 {
return errs
}

if err := p.nextConsumer.ConsumeMetrics(ctx, md); err != nil {
errs = errors.Join(errs, err)
}
Expand Down Expand Up @@ -223,6 +228,34 @@ func (p *Processor) exportMetrics() {
return out
}()

// Don't send empty metrics downstream
md.ResourceMetrics().RemoveIf(func(rm pmetric.ResourceMetrics) bool {
rm.ScopeMetrics().RemoveIf(func(sm pmetric.ScopeMetrics) bool {
sm.Metrics().RemoveIf(func(m pmetric.Metric) bool {
switch m.Type() {
case pmetric.MetricTypeSummary:
return m.Summary().DataPoints().Len() == 0
case pmetric.MetricTypeGauge:
return m.Gauge().DataPoints().Len() == 0
case pmetric.MetricTypeSum:
return m.Sum().DataPoints().Len() == 0
case pmetric.MetricTypeHistogram:
return m.Histogram().DataPoints().Len() == 0
case pmetric.MetricTypeExponentialHistogram:
return m.ExponentialHistogram().DataPoints().Len() == 0
default:
p.logger.Error("invalid MetricType", zap.Int32("type", int32(m.Type())))
return true
}
})
return sm.Metrics().Len() == 0
})
return rm.ScopeMetrics().Len() == 0
})
if md.ResourceMetrics().Len() == 0 {
return
}

if err := p.nextConsumer.ConsumeMetrics(p.ctx, md); err != nil {
p.logger.Error("Metrics export failed", zap.Error(err))
}
Expand Down
Loading