Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal/aws/awsutil] Refactor : Migrated from AWS Go SDK v1 to v2 #37910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Avinash-Acharya
Copy link

NOTE : This PR is not yet fully complete. I created it to seek guidance from the moderators regarding the necessary changes.

Description

This PR migrates the awsutil folder from AWS SDK v1 to v2. Since the internal/aws directory contains several subdirectories that require their own updates, I will be submitting separate PRs for each relevant folder within internal/aws/*. This approach follows the contribution guidelines for a easier review process.

One significant change in this PR is in the GetAWSConfig function. While the arguments passed to the function remain the same, its return value have changed:

  • Before: *aws.Config, *session.Session, error
  • After: *aws.Config, aws.Config, error

I’d appreciate any feedback on this change and whether it aligns with the expected design.

Link to tracking issue

Fixes #37728 and #36699

Testing

I used the go test -v command to run tests in the internal/aws/awsutil directory. Currently, I have commented out 4 out of 8 test functions due to failures, and I have included comments in the code explaining the reasons for each. I would appreciate guidance on resolving these issues.

@Avinash-Acharya Avinash-Acharya requested a review from a team as a code owner February 13, 2025 18:00
Copy link

linux-foundation-easycla bot commented Feb 13, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[internal/aws] migrate to AWS v2 SDK
2 participants