[chore] update genqlient to v0.8.0 and fix broken tests#37700
Conversation
adrielp
requested review from
a team,
TylerHelmuth,
andrzej-stencel and
crobert-1
as code owners
| go 1.22.1 | ||
| go 1.22.5 | ||
|
|
||
| toolchain go1.23.5 |
There was a problem hiding this comment.
Can we remove this line?
There was a problem hiding this comment.
Doesn't look like it. It popped up when running make tidy after I updated the genqlient version to v0.8.0.
I downloaded go 1.22.0 & go 1.22.5 just to see if using tidy with those versions would fix it. There's a dependency being updated that requires at least go1.22.12. Here's the response I get:
$ go1.22.0 mod tidy -compat=1.22.0
go: github.com/gostaticanalysis/testutil@v0.5.0 requires go >= 1.22.9; switching to go1.22.12And workflows fail when not having those values.
There was a problem hiding this comment.
It looks like this is coming from genqlient updating its go directive.
Since this is the only place that needed to be updated for CI/CD to pass, it's okay with me.
There was a problem hiding this comment.
internal/tools is fine, see also https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/35722#issuecomment-2438593913
5 participants
Description
They changed HTTP response handling in v0.8.0 so adjusted the tests to support the changes and updated the corresponding packages. Supersedes #37670
Link to tracking issue
Fixes #37670