Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/github] add support for tracing github actions #37462

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kevinschoonover
Copy link
Contributor

Description

Adds support for tracing github action executions. Github actions only gives up to seconds so things that take < 1 second are reported as 0.

image

Testing

Added basic scaffolding to unit tests the components, but unfamiliar with the best practices here.

Documentation

Updated the README to show the new functionality.

@adrielp
Copy link
Contributor

adrielp commented Jan 24, 2025

Hey @kevinschoonover -- greatly appreciate the initiative here on opening a PR to help drive things forward! Also happy to see interest and folks contributing to Otel.

I'd love to combine efforts here as I have a local branch that is almost ready, but has a lot of attribute specific things that I've been working with over on the semconv side. Right now, the latest version of semconv available to the collector is 1.27 but there are multiple changes in 1.29 that I've temporarily reimplemented directly in this receiver.

Not sure what the best way to join forces here is, but happy to chat here or on slack.

@kevinschoonover
Copy link
Contributor Author

Hey @adrielp. Thanks for reaching out - do you have a pointer to your branch where you have this? Im happy to join forces on that branch. Just saw this receiver when I was trying to alert on github action failures and thought Id spend a couple hours implementing this.

@adrielp
Copy link
Contributor

adrielp commented Jan 31, 2025

@kevinschoonover - sorry it's taken me so long to respond. I've been plugging away in 20 minute intervals once every few nights at this and been slow. Here's the pull request. I set it to draft as I still have a couple other things to take care of (removal of validation for scraper possibly, an additional test or three, header config change, and a documentation update). I loath creating branches off of branches, but I'm thinking about doing that for this one to break the PR's up a little bit (open to suggestion).

This one includes the workflow run event with deterministic trace and span ids. I'm looking for feedback on it. the model.go file is where most of the conventions are defined.

My branch is can be found here. I'm in CNCF slack for fastest response & the CICD SIG, where this is one of the things we've been talking about, is open everything Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants