Skip to content

[connector/routing] Mark MutatesData: true#37390

Merged
djaglowski merged 1 commit into
open-telemetry:mainfrom
djaglowski:routing-fix-mutates-data
Jan 21, 2025
Merged

[connector/routing] Mark MutatesData: true#37390
djaglowski merged 1 commit into
open-telemetry:mainfrom
djaglowski:routing-fix-mutates-data

Conversation

@djaglowski

@djaglowski djaglowski commented Jan 21, 2025

Copy link
Copy Markdown
Member
panic: invalid access to shared data

goroutine 5496 [running]:
go.opentelemetry.io/collector/pdata/internal.(*State).AssertMutable(...)
	/home/runner/go/pkg/mod/go.opentelemetry.io/collector/pdata@v1.22.0/internal/state.go:20
go.opentelemetry.io/collector/pdata/plog.LogRecordSlice.RemoveIf({0x14000726040?, 0x1400249c000?}, 0x136e82da8?)
	/home/runner/go/pkg/mod/go.opentelemetry.io/collector/pdata@v1.22.0/plog/generated_logrecordslice.go:108 +0x144
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector/internal/plogutil.MoveRecordsWithContextIf({0x14001a8c000?, 0x1400249c000?}, {0x14001a8d080?, 0x1400249c014?}, 0x14001b2cd30)
	/home/runner/go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector@v0.116.0/internal/plogutil/logs.go:36 +0x14c
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector.(*logsConnector).switchLogs(0x14002aa56e0, {0x10a491cf8, 0x10f2917c0}, {0x14001a8c000?, 0x1400249c000?})
	/home/runner/go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector@v0.116.0/logs.go:99 +0x1e0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector.(*logsConnector).ConsumeLogs(0x14001f78f20?, {0x10a491cf8?, 0x10f2917c0?}, {0x14001a8c000?, 0x1400249c000?})

@github-actions github-actions Bot requested review from jpkrohling and mwear January 21, 2025 21:11
@djaglowski djaglowski force-pushed the routing-fix-mutates-data branch 2 times, most recently from bc3aca7 to ef6d0ce Compare January 21, 2025 21:24
@djaglowski djaglowski force-pushed the routing-fix-mutates-data branch from ef6d0ce to 7fd970c Compare January 21, 2025 21:35
@djaglowski djaglowski marked this pull request as ready for review January 21, 2025 22:07
@djaglowski djaglowski requested a review from a team as a code owner January 21, 2025 22:07
@djaglowski djaglowski merged commit 76c1533 into open-telemetry:main Jan 21, 2025
@github-actions github-actions Bot added this to the next release milestone Jan 21, 2025
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
```
panic: invalid access to shared data

goroutine 5496 [running]:
go.opentelemetry.io/collector/pdata/internal.(*State).AssertMutable(...)
	/home/runner/go/pkg/mod/go.opentelemetry.io/collector/pdata@v1.22.0/internal/state.go:20
go.opentelemetry.io/collector/pdata/plog.LogRecordSlice.RemoveIf({0x14000726040?, 0x1400249c000?}, 0x136e82da8?)
	/home/runner/go/pkg/mod/go.opentelemetry.io/collector/pdata@v1.22.0/plog/generated_logrecordslice.go:108 +0x144
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector/internal/plogutil.MoveRecordsWithContextIf({0x14001a8c000?, 0x1400249c000?}, {0x14001a8d080?, 0x1400249c014?}, 0x14001b2cd30)
	/home/runner/go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector@v0.116.0/internal/plogutil/logs.go:36 +0x14c
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector.(*logsConnector).switchLogs(0x14002aa56e0, {0x10a491cf8, 0x10f2917c0}, {0x14001a8c000?, 0x1400249c000?})
	/home/runner/go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector@v0.116.0/logs.go:99 +0x1e0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector.(*logsConnector).ConsumeLogs(0x14001f78f20?, {0x10a491cf8?, 0x10f2917c0?}, {0x14001a8c000?, 0x1400249c000?})
```
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2025
```
panic: invalid access to shared data

goroutine 5496 [running]:
go.opentelemetry.io/collector/pdata/internal.(*State).AssertMutable(...)
	/home/runner/go/pkg/mod/go.opentelemetry.io/collector/pdata@v1.22.0/internal/state.go:20
go.opentelemetry.io/collector/pdata/plog.LogRecordSlice.RemoveIf({0x14000726040?, 0x1400249c000?}, 0x136e82da8?)
	/home/runner/go/pkg/mod/go.opentelemetry.io/collector/pdata@v1.22.0/plog/generated_logrecordslice.go:108 +0x144
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector/internal/plogutil.MoveRecordsWithContextIf({0x14001a8c000?, 0x1400249c000?}, {0x14001a8d080?, 0x1400249c014?}, 0x14001b2cd30)
	/home/runner/go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector@v0.116.0/internal/plogutil/logs.go:36 +0x14c
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector.(*logsConnector).switchLogs(0x14002aa56e0, {0x10a491cf8, 0x10f2917c0}, {0x14001a8c000?, 0x1400249c000?})
	/home/runner/go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector@v0.116.0/logs.go:99 +0x1e0
github.com/open-telemetry/opentelemetry-collector-contrib/connector/routingconnector.(*logsConnector).ConsumeLogs(0x14001f78f20?, {0x10a491cf8?, 0x10f2917c0?}, {0x14001a8c000?, 0x1400249c000?})
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants