[exporter/sematext] New component: Sematext Exporter #37161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exporter/sematextexporter/config.go
Outdated
| usLogsEndpoint = "https://logsene-receiver.sematext.com" | ||
| ) | ||
|
|
||
| type Config struct { |
There was a problem hiding this comment.
Please review (if you haven't already) the docs for adding new components:
- https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#when-adding-a-new-component
- https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components
I propose to split the code in the following way:
- First PR: empty Config struct
- Second PR: metrics config and functionality (initial minimum functionality if possible, to make reviewing easier)
- Third PR: logs config and functionality (initial minimum functionality if possible, to make reviewing easier)
I believe this will help greatly with the reviews.
There was a problem hiding this comment.
Is this okay? @andrzej-stencel
Co-authored-by: Andrzej Stencel <[email protected]>
Co-authored-by: Andrzej Stencel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First PR of New component: Sematext Exporter.
Link to tracking issue
#36465