-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance googlecloudmonitoringreceiver: Add Unit Tests for Metric Conversion and Improve Edge Case Coverage #36846
base: main
Are you sure you want to change the base?
Conversation
- Added unit tests for validating metric conversion logic in googlecloudmonitoringreceiver - Improved test coverage for edge cases in the receiver component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall. Lets just make the tests less fragile.
- Update testify error handling code - Add sample serviceAccount.json inside testdata
Updated all the changes |
Looks good. Just needs the CLA signed, and I think we are good to go |
i already proceed for CLA sign, waiting for approval. |
Ah, looks like there are linter failures: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12367918994/job/34537235029?pr=36846 |
- Resolve make lint issues
Can you please check now @dashpole |
Consider making NewFakeMetricTestServer and other testing-related artifacts not exported (lowercase) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36846 +/- ##
==========================================
+ Coverage 79.72% 79.86% +0.13%
==========================================
Files 2218 2218
Lines 209156 209252 +96
==========================================
+ Hits 166749 167118 +369
+ Misses 36836 36557 -279
- Partials 5571 5577 +6 ☔ View full report in Codecov by Sentry. |
- Run make checkapi
@TylerHelmuth @dashpole |
Description:
Added comprehensive test cases for the entire Google Cloud Monitoring Receiver component.
Link to tracking Issue:
#36815
Testing:
Implemented test cases to validate:
Documentation:
N/A