Skip to content

[connector/signaltometrics] Add boilerplate for the connector#36454

Merged
andrzej-stencel merged 10 commits into
open-telemetry:mainfrom
lahsivjar:add-signaltometrics-connector
Nov 25, 2024
Merged

[connector/signaltometrics] Add boilerplate for the connector#36454
andrzej-stencel merged 10 commits into
open-telemetry:mainfrom
lahsivjar:add-signaltometrics-connector

Conversation

@lahsivjar
Copy link
Copy Markdown
Member

@lahsivjar lahsivjar commented Nov 19, 2024 •
edited by ChrsMark
Loading

Description

Adds boilerplate code for a new signal to metrics connector.

Link to tracking issue

Part of #35930

Testing

Unit tests provided as required.

Documentation

Added basic README. Will add more details with future commits.

CC: @ChrsMark

@lahsivjar lahsivjar requested a review from a team as a code owner November 19, 2024 18:47
@lahsivjar lahsivjar force-pushed the add-signaltometrics-connector branch from dd4cd8a to 51abe4d Compare November 19, 2024 19:05
ChrsMark
ChrsMark reviewed Nov 20, 2024
View reviewed changes
Comment thread connector/signaltometricsconnector/config/config.go Outdated
@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Nov 20, 2024

@lahsivjar I changed the description to avoid closing the original issue after this PR gets merged. Let's leave the issue open until the competent is landed.

@github-actions github-actions Bot added the cmd/otelcontribcol otelcontribcol command label Nov 20, 2024
@lahsivjar lahsivjar requested a review from ChrsMark November 20, 2024 12:29
ChrsMark
ChrsMark reviewed Nov 20, 2024
View reviewed changes
Comment thread connector/signaltometricsconnector/config/config.go
Comment thread connector/signaltometricsconnector/config/config.go Outdated
Comment thread connector/signaltometricsconnector/config/config.go
@lahsivjar lahsivjar requested a review from ChrsMark November 20, 2024 16:02
ChrsMark
ChrsMark reviewed Nov 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's for adding the additional context @lahsivjar! I've left some minor comments but I think we can proceed with the specific design.

Comment thread reports/distributions/contrib.yaml Outdated
Comment thread connector/signaltometricsconnector/config/config.go Outdated
Comment thread connector/signaltometricsconnector/config/config.go Outdated
Comment thread cmd/otelcontribcol/builder-config.yaml Outdated
@lahsivjar lahsivjar requested a review from ChrsMark November 21, 2024 16:04
ChrsMark
ChrsMark approved these changes Nov 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@ChrsMark ChrsMark added the ready to merge Code review completed; ready to merge by maintainers label Nov 22, 2024
@andrzej-stencel andrzej-stencel merged commit 37129e9 into open-telemetry:main Nov 25, 2024
@github-actions github-actions Bot added this to the next release milestone Nov 25, 2024
@lahsivjar lahsivjar deleted the add-signaltometrics-connector branch November 25, 2024 15:59
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this pull request Dec 5, 2024
@lahsivjar @ChrsMark @shivanthzen
[connector/signaltometrics] Add boilerplate for the connector (open-t…
b56bb23 
…elemetry#36454)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds boilerplate code for a new signal to metrics connector.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Part of
open-telemetry#35930

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests provided as required.

<!--Describe the documentation added.-->
#### Documentation

Added basic README. Will add more details with future commits.
<!--Please delete paragraphs that you did not use before submitting.-->


CC: @ChrsMark

---------

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
@lahsivjar @ChrsMark @ZenoCC-Peng
[connector/signaltometrics] Add boilerplate for the connector (open-t…
27c2c68 
…elemetry#36454)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds boilerplate code for a new signal to metrics connector.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Part of
open-telemetry#35930

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests provided as required.

<!--Describe the documentation added.-->
#### Documentation

Added basic README. Will add more details with future commits.
<!--Please delete paragraphs that you did not use before submitting.-->


CC: @ChrsMark

---------

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@lahsivjar @ChrsMark @sbylica-splunk
[connector/signaltometrics] Add boilerplate for the connector (open-t…
970a67f 
…elemetry#36454)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds boilerplate code for a new signal to metrics connector.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Part of
open-telemetry#35930

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests provided as required.

<!--Describe the documentation added.-->
#### Documentation

Added basic README. Will add more details with future commits.
<!--Please delete paragraphs that you did not use before submitting.-->


CC: @ChrsMark

---------

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Jan 13, 2025
@lahsivjar @ChrsMark @AkhigbeEromo
[connector/signaltometrics] Add boilerplate for the connector (open-t…
245b71a 
…elemetry#36454)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds boilerplate code for a new signal to metrics connector.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Part of
open-telemetry#35930

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests provided as required.

<!--Describe the documentation added.-->
#### Documentation

Added basic README. Will add more details with future commits.
<!--Please delete paragraphs that you did not use before submitting.-->


CC: @ChrsMark

---------

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
@lahsivjar @ChrsMark @chengchuanpeng
[connector/signaltometrics] Add boilerplate for the connector (open-t…
3789bd0 
…elemetry#36454)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds boilerplate code for a new signal to metrics connector.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Part of
open-telemetry#35930

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests provided as required.

<!--Describe the documentation added.-->
#### Documentation

Added basic README. Will add more details with future commits.
<!--Please delete paragraphs that you did not use before submitting.-->

CC: @ChrsMark

---------

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2025
@lahsivjar @ChrsMark @zeck-ops
[connector/signaltometrics] Add boilerplate for the connector (open-t…
f0fcef6 
…elemetry#36454)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds boilerplate code for a new signal to metrics connector.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Part of
open-telemetry#35930

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests provided as required.

<!--Describe the documentation added.-->
#### Documentation

Added basic README. Will add more details with future commits.
<!--Please delete paragraphs that you did not use before submitting.-->


CC: @ChrsMark

---------

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@bogdandrutu bogdandrutu

Labels

cmd/otelcontribcol otelcontribcol command ready to merge Code review completed; ready to merge by maintainers reports/distributions/contrib.yaml

Projects

None yet

Milestone

v0.115.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lahsivjar @ChrsMark @bogdandrutu @andrzej-stencel