[cmd/githubgen] Add a flag to skip GitHub organization membership checks#36398
Merged
jpkrohling merged 1 commit intoNov 16, 2024
Merged
Conversation
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
atoulme
approved these changes
Nov 16, 2024
Contributor
|
Thank you! |
rshiyani
pushed a commit
to rshiyani/opentelemetry-collector-contrib
that referenced
this pull request
Dec 9, 2024
…cks (open-telemetry#36398) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds a `--skipgithub` flag to allow generating the `CODEOWNERS` file without requiring a PAT to verify membership in the OpenTelemetry GitHub organization. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36263 <!--Describe what testing was performed and which tests were added.--> #### Testing Executed command without providing a PAT and confirmed it did not produce errors or unexpected changes to the `CODEOWNERS` file. <!--Describe the documentation added.--> #### Documentation Updated `README` <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…cks (open-telemetry#36398) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds a `--skipgithub` flag to allow generating the `CODEOWNERS` file without requiring a PAT to verify membership in the OpenTelemetry GitHub organization. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36263 <!--Describe what testing was performed and which tests were added.--> #### Testing Executed command without providing a PAT and confirmed it did not produce errors or unexpected changes to the `CODEOWNERS` file. <!--Describe the documentation added.--> #### Documentation Updated `README` <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--skipgithubflag to allow generating theCODEOWNERSfile without requiring a PAT to verify membership in the OpenTelemetry GitHub organization.Link to tracking issue
Fixes #36263
Testing
Executed command without providing a PAT and confirmed it did not produce errors or unexpected changes to the
CODEOWNERSfile.Documentation
Updated
README